From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 4BC09E0096A; Mon, 13 Aug 2018 18:07:16 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [198.47.23.249 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 652C2E006D8 for ; Mon, 13 Aug 2018 18:07:15 -0700 (PDT) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id w7E17ESn071125 for ; Mon, 13 Aug 2018 20:07:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1534208834; bh=J+2WDiXul2PRvto5ZOyZQVLaUUifnBDw1XjDcNA/jyE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=yWOlhmKno991rBGPriBRbJ6tRlpyIBRJrppdQwokmfohjMii+Fjv3S4BNeA8LqhvI VGWPJDzjBaeKedKFejaZVrvqKRRGqwJaMVe5rxpViYVaJK3J34mcQqCjgjSp8xg8my DmIi9CR/oDD5jafMtDa10n5FmVHWDrmuxfZcMtzY= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w7E17E2u029366 for ; Mon, 13 Aug 2018 20:07:14 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 13 Aug 2018 20:07:14 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Mon, 13 Aug 2018 20:07:14 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w7E17Elb022592; Mon, 13 Aug 2018 20:07:14 -0500 Date: Mon, 13 Aug 2018 21:06:09 -0400 From: Denys Dmytriyenko To: Nick Saulnier Message-ID: <20180814010609.GA2547@beryl> References: <1534188863-8838-1-git-send-email-nsaulnier@ti.com> MIME-Version: 1.0 In-Reply-To: <1534188863-8838-1-git-send-email-nsaulnier@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-ti@yoctoproject.org Subject: Re: [PATCH v1] pru-icss_git.bb: Add am65x PRU_Halt X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 01:07:16 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Aug 13, 2018 at 02:34:23PM -0500, Nick Saulnier wrote: > Updated SRCREV to point to an updated version of the PRU Software Support > Package which includes PRU_Halt and RTU_Halt examples for am65x. PV will > get updated in the next patch. > > Added PRU_Halt and RTU_Halt to do_install_append_am65xx-evm(). Decided to leave > the installation of PRU_Halt examples in each processor's do_install_append > function for now since PRU_Halt and RTU_Halt for am65x have different output > file names than the previous ICSS processors. Those different output names can > be seen in the lines ALTERNATIVE_TARGET_pru-icss-halt[am65x....]. > > The previous commit made several changes to account for the fact that am65x Halt > examples had not yet been added to the PRU Software Support Package. I tried to > comment out those temporary changes from the previous commit. The commented > lines will be removed in a future patch once we verify that I commented the > correct lines of code. Thanks, looks good. Do you expect more functional changes in the next patch? If not, I'd suggest cleaning commented out lines in v2. > Signed-off-by: Nick Saulnier > --- > recipes-bsp/pru/pru-icss_git.bb | 35 ++++++++++++++++++++++++++++------- > 1 file changed, 28 insertions(+), 7 deletions(-) > > diff --git a/recipes-bsp/pru/pru-icss_git.bb b/recipes-bsp/pru/pru-icss_git.bb > index 3c871b70e3f0..7d23b3d066f8 100644 > --- a/recipes-bsp/pru/pru-icss_git.bb > +++ b/recipes-bsp/pru/pru-icss_git.bb > @@ -8,10 +8,10 @@ inherit update-alternatives > > BRANCH = "master" > SRC_URI = "git://git.ti.com/pru-software-support-package/pru-software-support-package.git;protocol=git;branch=${BRANCH}" > -SRCREV = "81b568741b8b98e6f590271a9aea5956d2b2d9ce" > +SRCREV = "1d9249c012005a669a6ffb2f76255d72ed5c0e4c" > > PV = "5.2.1" > -PR = "r1" > +PR = "r2" > > require recipes-ti/includes/ti-paths.inc > > @@ -103,6 +103,13 @@ do_install_append_k2g() { > } > > do_install_append_am65xx-evm() { > + for i in 0 1 > + do > + install -m 644 ${S}/examples/${PLATFORM}/PRU_Halt/gen/PRU${i}/PRU_Halt_${i}.out \ > + ${D}/lib/firmware/pru > + install -m 644 ${S}/examples/${PLATFORM}/RTU_Halt/gen/RTU${i}/RTU_Halt_${i}.out \ > + ${D}/lib/firmware/pru > + done > for i in 0 1 2 > do > for j in 0 1 > @@ -116,7 +123,7 @@ do_install_append_am65xx-evm() { > done > } > > -FILES_${PN}-halt = "/lib/firmware/pru/PRU_Halt.out" > +FILES_${PN}-halt = "/lib/firmware/pru/PRU_Halt* /lib/firmware/pru/RTU_Halt*" > FILES_${PN}-rpmsg-echo = "/lib/firmware/pru/PRU_RPMsg_Echo_Interrupt* /lib/firmware/pru/RTU_RPMsg_Echo_Interrupt*" > > # Set up names for the firmwares > @@ -161,8 +168,8 @@ ALTERNATIVE_LINK_NAME[am65x-rtu2_1-fw] = "/lib/firmware/am65x-rtu2_1-fw" > # Create the pru-icss-halt firmware alternatives > ALTERNATIVE_pru-icss-halt = "${PRU_ICSS_ALTERNATIVES}" > > -# am65xx doesn't have halt FW for now > -ALTERNATIVE_pru-icss-halt_am65xx-evm = "" > +# since am65xx now has halt, we can comment out the line below right? > +#ALTERNATIVE_pru-icss-halt_am65xx-evm = "" > > ALTERNATIVE_TARGET_pru-icss-halt[am335x-pru0-fw] = "/lib/firmware/pru/PRU_Halt.out" > ALTERNATIVE_TARGET_pru-icss-halt[am335x-pru1-fw] = "/lib/firmware/pru/PRU_Halt.out" > @@ -182,6 +189,19 @@ ALTERNATIVE_TARGET_pru-icss-halt[k2g-pru0_1-fw] = "/lib/firmware/pru/PRU_Halt.ou > ALTERNATIVE_TARGET_pru-icss-halt[k2g-pru1_0-fw] = "/lib/firmware/pru/PRU_Halt.out" > ALTERNATIVE_TARGET_pru-icss-halt[k2g-pru1_1-fw] = "/lib/firmware/pru/PRU_Halt.out" > > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-pru0_0-fw] = "/lib/firmware/pru/PRU_Halt_0.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-pru0_1-fw] = "/lib/firmware/pru/PRU_Halt_1.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-pru1_0-fw] = "/lib/firmware/pru/PRU_Halt_0.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-pru1_1-fw] = "/lib/firmware/pru/PRU_Halt_1.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-pru2_0-fw] = "/lib/firmware/pru/PRU_Halt_0.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-pru2_1-fw] = "/lib/firmware/pru/PRU_Halt_1.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-rtu0_0-fw] = "/lib/firmware/pru/RTU_Halt_0.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-rtu0_1-fw] = "/lib/firmware/pru/RTU_Halt_1.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-rtu1_0-fw] = "/lib/firmware/pru/RTU_Halt_0.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-rtu1_1-fw] = "/lib/firmware/pru/RTU_Halt_1.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-rtu2_0-fw] = "/lib/firmware/pru/RTU_Halt_0.out" > +ALTERNATIVE_TARGET_pru-icss-halt[am65x-rtu2_1-fw] = "/lib/firmware/pru/RTU_Halt_1.out" > + > ALTERNATIVE_PRIORITY_pru-icss-halt = "50" > > # Create the pru-icss-rpmsg-echo firmware alternatives > @@ -220,8 +240,9 @@ ALTERNATIVE_TARGET_pru-icss-rpmsg-echo[am65x-rtu2_1-fw] = "/lib/firmware/pru/RTU > > ALTERNATIVE_PRIORITY_pru-icss-rpmsg-echo = "100" > > -# am65xx doesn't have halt FW for now > -ALLOW_EMPTY_${PN}-halt = "1" > +# Since am65xx how has halt, we can comment out ALLOW_EMPTY_-halt now right? > +# old comment: am65xx doesn't have halt FW for now > +#ALLOW_EMPTY_${PN}-halt = "1" > > ALLOW_EMPTY_${PN} = "1" > > -- > 1.9.1 >