From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Date: Tue, 14 Aug 2018 13:42:32 +0000 Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path Message-Id: <20180814134232.GC2211@lunn.ch> List-Id: References: <20180814090905.rm6i665c5utl7d32@kili.mountain> In-Reply-To: <20180814090905.rm6i665c5utl7d32@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Aug 14, 2018 at 12:09:05PM +0300, Dan Carpenter wrote: > We added a new error path, but we need to drop the lock before we return. > > Fixes: 2d2e1dd29962 ("net: dsa: mv88e6xxx: Cache the port cmode") > Signed-off-by: Dan Carpenter Signed-off-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: missing unlock on error path Date: Tue, 14 Aug 2018 15:42:32 +0200 Message-ID: <20180814134232.GC2211@lunn.ch> References: <20180814090905.rm6i665c5utl7d32@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:35013 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732699AbeHNQ3v (ORCPT ); Tue, 14 Aug 2018 12:29:51 -0400 Content-Disposition: inline In-Reply-To: <20180814090905.rm6i665c5utl7d32@kili.mountain> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Aug 14, 2018 at 12:09:05PM +0300, Dan Carpenter wrote: > We added a new error path, but we need to drop the lock before we return. > > Fixes: 2d2e1dd29962 ("net: dsa: mv88e6xxx: Cache the port cmode") > Signed-off-by: Dan Carpenter Signed-off-by: Andrew Lunn Andrew