All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/aircrack-ng: powerpc arch requires altivec
Date: Tue, 14 Aug 2018 14:30:47 +0200	[thread overview]
Message-ID: <20180814143047.167c3c26@windsurf> (raw)
In-Reply-To: <20180814021937.22330-1-matthew.weber@rockwellcollins.com>

Hello Matt,

On Mon, 13 Aug 2018 21:19:37 -0500, Matt Weber wrote:
> The powerpc support in this package requires an arch with altivec
> accelerator support.  The package is currently just building powerpc
> assuming a Power8\Altivec.
> 
> Fixes
> http://autobuild.buildroot.net/results/87e82a5e8d0b1c1ff10ec3e59d25bcd56b329075
> 
> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/aircrack-ng/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/aircrack-ng/Config.in b/package/aircrack-ng/Config.in
> index f3e2bc4ef1..48e743a174 100644
> --- a/package/aircrack-ng/Config.in
> +++ b/package/aircrack-ng/Config.in
> @@ -4,6 +4,8 @@ config BR2_PACKAGE_AIRCRACK_NG
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	depends on BR2_POWERPC_CPU_HAS_ALTIVEC  || \
> +		!(BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le)

This looks like the wrong fix. The Altivec code in Aircrack-ng is not
mandatory, just like the ARM NEON code is not mandatory. There is some
other issue that causes the build failure.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-08-14 12:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14  2:19 [Buildroot] [PATCH] package/aircrack-ng: powerpc arch requires altivec Matt Weber
2018-08-14 12:30 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814143047.167c3c26@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.