From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Date: Wed, 15 Aug 2018 04:32:33 +0200 Message-ID: <20180815023233.GD11610@lunn.ch> References: <20180814141240.9085-1-a.fatoum@pengutronix.de> <20180814155812.cjuacvkhqeuctcry@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Ahmad Fatoum , "David S. Miller" , Nicolas Ferre , netdev@vger.kernel.org, mdf@kernel.org, stable@vger.kernel.org, kernel@pengutronix.de, Brad Mouring , Florian Fainelli To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:35521 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbeHOFWr (ORCPT ); Wed, 15 Aug 2018 01:22:47 -0400 Content-Disposition: inline In-Reply-To: <20180814155812.cjuacvkhqeuctcry@pengutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Aug 14, 2018 at 05:58:12PM +0200, Uwe Kleine-König wrote: > Hello Ahmad, > > > On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > > The referenced commit broke initializing macb on the EVB-KSZ9477 eval board. > > There, of_mdiobus_register was called even for the fixed-link representing > > the SPI-connected switch PHY, with the result that the driver attempts to > > enumerate PHYs on a non-existent MDIO bus: > > > > libphy: MACB_mii_bus: probed > > mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address > > mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0 > > [snip] > > mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31 > > macb f0028000.ethernet: broken fixed-link specification > > > > Cc: > > Fixes: 739de9a1563a ("net: macb: Reorganize macb_mii bringup") > > I added the people involved in 739de9a1563a to Cc. Maybe they want to > comment. So not stripping the remaining part of the original mail. Thanks Uwe for Cc: in my. Ahmed, where is the device tree for the EVB-KSZ9477? Thanks Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vps0.lunn.ch ([185.16.172.187]:35521 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbeHOFWr (ORCPT ); Wed, 15 Aug 2018 01:22:47 -0400 Date: Wed, 15 Aug 2018 04:32:33 +0200 From: Andrew Lunn To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Ahmad Fatoum , "David S. Miller" , Nicolas Ferre , netdev@vger.kernel.org, mdf@kernel.org, stable@vger.kernel.org, kernel@pengutronix.de, Brad Mouring , Florian Fainelli Subject: Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Message-ID: <20180815023233.GD11610@lunn.ch> References: <20180814141240.9085-1-a.fatoum@pengutronix.de> <20180814155812.cjuacvkhqeuctcry@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180814155812.cjuacvkhqeuctcry@pengutronix.de> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Aug 14, 2018 at 05:58:12PM +0200, Uwe Kleine-K�nig wrote: > Hello Ahmad, > > > On Tue, Aug 14, 2018 at 04:12:40PM +0200, Ahmad Fatoum wrote: > > The referenced commit broke initializing macb on the EVB-KSZ9477 eval board. > > There, of_mdiobus_register was called even for the fixed-link representing > > the SPI-connected switch PHY, with the result that the driver attempts to > > enumerate PHYs on a non-existent MDIO bus: > > > > libphy: MACB_mii_bus: probed > > mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address > > mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0 > > [snip] > > mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31 > > macb f0028000.ethernet: broken fixed-link specification > > > > Cc: > > Fixes: 739de9a1563a ("net: macb: Reorganize macb_mii bringup") > > I added the people involved in 739de9a1563a to Cc. Maybe they want to > comment. So not stripping the remaining part of the original mail. Thanks Uwe for Cc: in my. Ahmed, where is the device tree for the EVB-KSZ9477? Thanks Andrew