From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RESEND] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd
Date: Wed, 15 Aug 2018 13:51:14 +0100 [thread overview]
Message-ID: <20180815125114.GV6515@ZenIV.linux.org.uk> (raw)
In-Reply-To: <5B73C5D402000078001DE189@prv1-mh.provo.novell.com>
On Wed, Aug 15, 2018 at 12:19:00AM -0600, Jan Beulich wrote:
> While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP
> require more work), it at least allows some simple operations (like
> "xl dmesg") which have always been available on XenoLinux to work again
> with a 64-bit kernel underneath a 32-bit distro.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Juergen Gross <jgross@suse.com>
Nacked-by: Al Viro <viro@zeniv.linux.org.uk>
This belongs in drivers/xen/privcmd.c, not in fs/compat_ioctl.c
*ANY* single-driver ioctl definitely should be handled by ->compat_ioctl()
method and any patches dumping such stuff into fs/compat_ioctl.c will be
rejected.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Beulich <JBeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RESEND] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd
Date: Wed, 15 Aug 2018 13:51:14 +0100 [thread overview]
Message-ID: <20180815125114.GV6515@ZenIV.linux.org.uk> (raw)
In-Reply-To: <5B73C5D402000078001DE189@prv1-mh.provo.novell.com>
On Wed, Aug 15, 2018 at 12:19:00AM -0600, Jan Beulich wrote:
> While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP
> require more work), it at least allows some simple operations (like
> "xl dmesg") which have always been available on XenoLinux to work again
> with a 64-bit kernel underneath a 32-bit distro.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Juergen Gross <jgross@suse.com>
Nacked-by: Al Viro <viro@zeniv.linux.org.uk>
This belongs in drivers/xen/privcmd.c, not in fs/compat_ioctl.c
*ANY* single-driver ioctl definitely should be handled by ->compat_ioctl()
method and any patches dumping such stuff into fs/compat_ioctl.c will be
rejected.
next prev parent reply other threads:[~2018-08-15 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 10:41 [PATCH] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd Jan Beulich
2018-08-15 6:19 ` [PATCH RESEND] " Jan Beulich
2018-08-15 6:19 ` Jan Beulich
2018-08-15 12:41 ` Christoph Hellwig
2018-08-15 12:41 ` Christoph Hellwig
2018-08-15 12:51 ` Al Viro [this message]
2018-08-15 12:51 ` Al Viro
2018-08-15 13:16 ` Jan Beulich
2018-08-15 13:16 ` Jan Beulich
2018-08-15 13:27 ` Al Viro
2018-08-15 13:27 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815125114.GV6515@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.