From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 8/8] package/mender: set version in go linker
Date: Wed, 15 Aug 2018 14:43:12 +0200 [thread overview]
Message-ID: <20180815144312.09b9ff96@windsurf> (raw)
In-Reply-To: <CADHdJwBGQKrWPiLOio9oz5k-xrL-+CUNo+WAJf-Q6vUbOdiU7g@mail.gmail.com>
Hello,
On Wed, 15 Aug 2018 14:32:23 +0200, Mirza Krak wrote:
> I would not know the answer to this as my experience is somewhat
> limited when it comes to golang. But if we take a look at
> docker-containerd.mk, it does this:
>
> DOCKER_CONTAINERD_LDFLAGS = \
> -X
> github.com/docker/containerd.GitCommit=$(DOCKER_CONTAINERD_VERSION)
>
> Maybe above an argument against putting it in pkg-golank.mk?
Indeed, every package seems to use its own custom property, so your
patch looks good. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-08-15 12:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 23:13 [Buildroot] [PATCH 0/8] various improvements to package/mender Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 1/8] package/mender: update legal info Mirza Krak
2018-08-14 23:32 ` Arnout Vandecappelle
2018-08-15 7:37 ` Mirza Krak
2018-08-16 15:36 ` Arnout Vandecappelle
2018-08-16 19:59 ` Mirza Krak
2018-08-16 20:18 ` Mirza Krak
2018-08-17 3:48 ` Baruch Siach
2018-08-17 6:53 ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 2/8] package/mender: update install of config files Mirza Krak
2018-08-15 12:31 ` Thomas Petazzoni
2018-08-15 12:42 ` Mirza Krak
2018-08-15 17:41 ` Thomas Petazzoni
2018-08-15 18:48 ` Mirza Krak
2018-08-15 19:02 ` Thomas Petazzoni
2018-08-14 23:13 ` [Buildroot] [PATCH 3/8] package/mender: add dep on BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV Mirza Krak
2018-08-15 5:08 ` Baruch Siach
2018-08-15 7:21 ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 4/8] package/mender: add BR2_PACKAGE_MENDER_ARTIFACT_NAME option Mirza Krak
2018-08-15 5:10 ` Baruch Siach
2018-08-15 7:23 ` Mirza Krak
2018-08-15 11:53 ` Thomas Petazzoni
2018-08-15 12:23 ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 5/8] package/mender: add BR2_PACKAGE_MENDER_DEVICE_TYPE option Mirza Krak
2018-08-15 11:55 ` Thomas Petazzoni
2018-08-15 12:26 ` Mirza Krak
2018-08-15 12:42 ` Thomas Petazzoni
2018-08-15 12:46 ` Mirza Krak
2018-08-15 17:47 ` Thomas Petazzoni
2018-08-15 19:41 ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 6/8] package/mender: populate the mender.conf template Mirza Krak
2018-08-15 11:56 ` Thomas Petazzoni
2018-08-15 12:27 ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 7/8] package/mender: select BR2_PACKAGE_CA_CERTIFICATES Mirza Krak
2018-08-15 11:57 ` Thomas Petazzoni
2018-08-15 12:28 ` Mirza Krak
2018-08-14 23:13 ` [Buildroot] [PATCH 8/8] package/mender: set version in go linker Mirza Krak
2018-08-15 11:58 ` Thomas Petazzoni
2018-08-15 12:32 ` Mirza Krak
2018-08-15 12:43 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815144312.09b9ff96@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.