From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] New <pkg>-update-last-config-fragment target in pkg-kconfig.mk
Date: Wed, 15 Aug 2018 18:16:57 +0200 [thread overview]
Message-ID: <20180815161657.GC2556@scaer> (raw)
In-Reply-To: <20180815140413.62984968@windsurf>
Thomas, Arnout, Marcel, All,
On 2018-08-15 14:04 +0200, Thomas Petazzoni spake thusly:
> On Wed, 15 Aug 2018 01:20:29 +0200, Arnout Vandecappelle wrote:
> > > Marcel, do you think you could rework your patch series to go in the
> > > direction of showing a diff rather than arbitrarily adjusting the last
> > > fragment ?
> >
> > Note that the diff really applies to the last fragment only, in the sense that
> > if the last fragment is setting CONFIG_BAR, the "is unset" bit has to come after
> > it. I don't think there is a way to say anything sensible automatically except
> > for the last fragment.
>
> Yes, the diff cannot be blindly applied to anything but the last
> fragment. But the idea in showing the diff is not for the user to apply
> it blindly, but rather to determine which parts of the diff should be
> reflected to each fragment.
Indeed, it is not to be considered to be a diff of any of the fragment,
but of the configuration *as a whole*.
That's why I initially did not write a full diff, but only the delta
snippet, not the context, because it is a diff, not a patch.
But I think we should instead use the scripts/diffconfig script that is
in the linux kernel tree, and which outputs looks like:
$ cat config.000
CONFIG_FOO=y
$ cat config.001
CONFIG_FOO is not set
$ ./scripts/diffconfig config.000 config.001
FOO y -> n
which IMNSHO is exactly the message we want to convey.
Regards,
Yann E. MORIN.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-08-15 16:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 15:51 [Buildroot] [PATCH 0/3] Buildroot: Target to update config fragments in kconfig based packages Marcel Patzlaff
2018-07-30 15:51 ` [Buildroot] [PATCH 1/3] Support script for defconfig comparison Marcel Patzlaff
2018-07-30 15:51 ` [Buildroot] [PATCH 2/3] Refactoring of pkg-kconfig.mk to increase re-usability Marcel Patzlaff
2018-07-30 15:51 ` [Buildroot] [PATCH 3/3] New <pkg>-update-last-config-fragment target in pkg-kconfig.mk Marcel Patzlaff
2018-07-30 21:46 ` Thomas Petazzoni
2018-07-31 7:44 ` [Buildroot] Antwort: " Marcel Patzlaff
2018-07-31 7:53 ` [Buildroot] " Thomas Petazzoni
2018-07-31 8:43 ` [Buildroot] Antwort: " Marcel Patzlaff
2018-07-31 15:49 ` [Buildroot] " Yann E. MORIN
2018-08-14 14:27 ` Thomas Petazzoni
2018-08-14 15:29 ` Yann E. MORIN
2018-08-14 23:20 ` Arnout Vandecappelle
2018-08-15 12:04 ` Thomas Petazzoni
2018-08-15 16:16 ` Yann E. MORIN [this message]
2018-08-15 17:35 ` Thomas Petazzoni
2018-08-15 20:29 ` Yann E. MORIN
2018-08-15 22:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815161657.GC2556@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.