From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()" Date: Thu, 16 Aug 2018 08:04:13 +0200 Message-ID: <20180816060413.GA29723@kroah.com> References: <1534339268-111834-1-git-send-email-maowenan@huawei.com> <1534339268-111834-2-git-send-email-maowenan@huawei.com> <20180815131807.GA31330@kroah.com> <865f3aa5-e763-a5fe-9ab0-eab42e0fc310@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dwmw2@infradead.org, netdev@vger.kernel.org, eric.dumazet@gmail.com, edumazet@google.com, davem@davemloft.net, ycheng@google.com, jdw@amazon.de To: maowenan Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50823 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387491AbeHPJAV (ORCPT ); Thu, 16 Aug 2018 05:00:21 -0400 Content-Disposition: inline In-Reply-To: <865f3aa5-e763-a5fe-9ab0-eab42e0fc310@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Aug 16, 2018 at 09:55:42AM +0800, maowenan wrote: > > > On 2018/8/15 21:18, Greg KH wrote: > > On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: > >> This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. > > > > I need a reason why, and a signed-off-by line :( > > stable 4.4 only back port two patches to fix CVE-2018-5390, I have tested they can't > fix fully because of simple queue used in lower version, so we need change simple queue > to RB tree to finally resolve. But 9f5afeae have many conflicts with tcp: detect malicious patterns in tcp_collapse_ofo_queue() > and tcp: avoid collapses in tcp_prune_queue() if possible, and there are patch series from Eric in mainline to fix CVE-2018-5390, > so I need revert part of patches in stable 4.4 firstly, then apply 9f5afeae, and reapply five patches from Eric. > 9f5afeae tcp: use an RB tree for ooo receive queue Then please put this information in the changelog text, that's what we need to see here. thanks, greg k-h