From: kbuild test robot <fengguang.wu@intel.com>
To: Roy Im <roy.im.opensource@diasemi.com>
Cc: kbuild-all@01.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Support Opensource <support.opensource@diasemi.com>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Input: fix boolreturn.cocci warnings
Date: Thu, 16 Aug 2018 14:46:02 +0800 [thread overview]
Message-ID: <20180816064602.GA94754@cairo> (raw)
In-Reply-To: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com>
From: kbuild test robot <fengguang.wu@intel.com>
drivers/input/misc/da7280.c:116:9-10: WARNING: return of 0/1 in function 'da7280_volatile_register' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: a067f5d53e35 ("Input: new da7280 haptic driver")
CC: Roy Im <roy.im.opensource@diasemi.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
da7280.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/input/misc/da7280.c
+++ b/drivers/input/misc/da7280.c
@@ -113,9 +113,9 @@ static bool da7280_volatile_register(str
case DA7280_IRQ_EVENT_SEQ_DIAG:
case DA7280_IRQ_STATUS1:
case DA7280_TOP_CTL1:
- return 1;
+ return true;
default:
- return 0;
+ return false;
}
}
next prev parent reply other threads:[~2018-08-16 6:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 2:02 [PATCH V1 0/3] da7280: haptic driver submission Roy Im
2018-08-16 2:02 ` Roy Im
2018-08-16 2:02 ` [PATCH V1 3/3] Input: new da7280 haptic driver Roy Im
2018-08-16 2:02 ` Roy Im
2018-08-16 6:46 ` kbuild test robot
2018-08-16 6:46 ` kbuild test robot [this message]
2018-08-16 6:46 ` [PATCH] Input: fix irqf_oneshot.cocci warnings kbuild test robot
2018-08-16 2:02 ` [PATCH V1 1/3] MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms Roy Im
2018-08-16 2:02 ` Roy Im
2018-08-16 2:02 ` [PATCH V1 2/3] Documentation: devicetree: input: new binding for da7280 Roy Im
2018-08-16 2:02 ` Roy Im
-- strict thread matches above, loose matches on Subject: below --
2021-02-18 9:59 drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in function 'zinitix_init_touch' with return type bool kernel test robot
2021-02-18 9:59 ` [PATCH] Input: fix boolreturn.cocci warnings kernel test robot
2021-02-18 9:59 ` kernel test robot
2021-02-19 3:35 ` Dmitry Torokhov
2021-02-19 3:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816064602.GA94754@cairo \
--to=fengguang.wu@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=roy.im.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.