From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver Date: Thu, 16 Aug 2018 09:42:10 +0100 Message-ID: <20180816084210.GB10054@dell> References: <20180812184152.GA22343@ravnborg.org> <20180812184629.3808-3-sam@ravnborg.org> <20180815052435.GA6412@dell> <20180815204041.GA29041@ravnborg.org> <1afc6d63-094b-3bff-87e9-d2354602ba76@microchip.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1afc6d63-094b-3bff-87e9-d2354602ba76@microchip.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicolas Ferre Cc: Mark Rutland , devicetree@vger.kernel.org, Alexandre Belloni , linux-pwm@vger.kernel.org, Boris Brezillon , dri-devel@lists.freedesktop.org, Boris Brezillon , Rob Herring , Sam Ravnborg , linux-arm-kernel@lists.infradead.org List-Id: linux-pwm@vger.kernel.org T24gVGh1LCAxNiBBdWcgMjAxOCwgTmljb2xhcyBGZXJyZSB3cm90ZToKCj4gT24gMTUvMDgvMjAx OCBhdCAyMjo0MCwgU2FtIFJhdm5ib3JnIHdyb3RlOgo+ID4gSGkgTGVlLgo+ID4gCj4gPiA+ID4g Kwo+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG1mZF9jZWxsIGxjZGNfY2VsbHNbXSA9IHsK PiA+ID4gPiArCXsKPiA+ID4gPiArCQkubmFtZSA9ICJhdG1lbC1sY2RjLXB3bSIsCj4gPiA+ID4g KwkJLm9mX2NvbXBhdGlibGUgPSAiYXRtZWwsbGNkYy1wd20iLAo+ID4gPiA+ICsJfSwKPiA+ID4g PiArCXsKPiA+ID4gPiArCQkubmFtZSA9ICJhdG1lbC1sY2RjLWRjIiwKPiA+ID4gPiArCQkub2Zf Y29tcGF0aWJsZSA9ICJhdG1lbCxsY2RjLWRpc3BsYXktY29udHJvbGxlciIsCj4gPiA+ID4gKwl9 LAo+ID4gPiA+ICt9Owo+ID4gPiAKPiA+ID4gV2lsbCB5b3UgYmUgYWRkaW5nIGFueSBtb3JlIGRl dmljZXMsIG9yIGlzIHRoaXMgdGhlIGVudGlyZXR5IG9mIHRoZQo+ID4gPiBkZXZpY2U/ICBJZiB0 aGUgbGF0dGVyLCBJIHN1Z2dlc3QgdGhhdCB0aGlzIGRvZXNuJ3Qgd2FycmFudCBiZWluZyBhbgo+ ID4gPiBNRkQuCj4gPiBUaGF0cyBpdC4gQW5kIG90aGVycyBhZ3JlZSB3aXRoIHlvdSB0aGF0IHRo aXMgaXMgbm90IGEgZ29vZCBhcHByb2FjaC4KPiA+IFNvIGluIHYyIHRoZXJlIHdpbGwgYmUgbm8g TUZELgo+ID4gCj4gPiBUaGFua3MgZm9yIGNvbmZpcm1pbmcgdGhhdCB0aGUgbm9uLW1mZCB3YXkg aXMgdGhlIGJldHRlciBhcHByb2FjaC4KPiAKPiBNRkQgYXBwcm9hY2ggd291bGQgaGF2ZSBoYWQg dGhlIGJlbmVmaXQgb2Yga2VlcGluZyB0aGlzIGRyaXZlciBzZXJpZXMKPiBhcmNoaXRlY3R1cmUg Y2xvc2UgdG8gdGhlIEhMQ0Qgb25lLiBUaGlzIHdvdWxkIGhhdmUgYmVlbiBlYXNpZXIgdG8KPiB1 bmRlcnN0YW5kIGFuZCB1c2Ugb25lIFNvQyBvciBhbm90aGVyIG9uZSBmcm9tIHRoZSBBVDkxIHBy b2R1Y3QgbGluZS4uLi4KClllcywgdGhhdCBpcyB0cnVlLiAgVGhleSBhcmUgdmVyeSBzaW1pbGFy IGRyaXZlcnMuICBXb3VsZCBpdCBtYWtlCnNlbnNlIHRvIHVzZSB0aGUgc2FtZSBkcml2ZXIgZm9y IGJvdGggZGV2aWNlcz8KCj4gQW55d2F5LCBJJ2Qgd2FpdCBmb3IgQm9yaXMnIGZlZWRiYWNrIGZv ciBtYWtpbmcgYSBkZWNpc2lvbi4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNl cnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJl IGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 16 Aug 2018 09:42:10 +0100 Subject: [PATCH v1 3/7] mfd: add atmel-lcdc driver In-Reply-To: <1afc6d63-094b-3bff-87e9-d2354602ba76@microchip.com> References: <20180812184152.GA22343@ravnborg.org> <20180812184629.3808-3-sam@ravnborg.org> <20180815052435.GA6412@dell> <20180815204041.GA29041@ravnborg.org> <1afc6d63-094b-3bff-87e9-d2354602ba76@microchip.com> Message-ID: <20180816084210.GB10054@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 16 Aug 2018, Nicolas Ferre wrote: > On 15/08/2018 at 22:40, Sam Ravnborg wrote: > > Hi Lee. > > > > > > + > > > > +static const struct mfd_cell lcdc_cells[] = { > > > > + { > > > > + .name = "atmel-lcdc-pwm", > > > > + .of_compatible = "atmel,lcdc-pwm", > > > > + }, > > > > + { > > > > + .name = "atmel-lcdc-dc", > > > > + .of_compatible = "atmel,lcdc-display-controller", > > > > + }, > > > > +}; > > > > > > Will you be adding any more devices, or is this the entirety of the > > > device? If the latter, I suggest that this doesn't warrant being an > > > MFD. > > Thats it. And others agree with you that this is not a good approach. > > So in v2 there will be no MFD. > > > > Thanks for confirming that the non-mfd way is the better approach. > > MFD approach would have had the benefit of keeping this driver series > architecture close to the HLCD one. This would have been easier to > understand and use one SoC or another one from the AT91 product line.... Yes, that is true. They are very similar drivers. Would it make sense to use the same driver for both devices? > Anyway, I'd wait for Boris' feedback for making a decision. -- Lee Jones [???] Linaro Services Technical Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog