From: Stephen Hemminger <stephen@networkplumber.org>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 1/2] hexdump: whitespace cleanup
Date: Thu, 16 Aug 2018 09:59:41 -0700 [thread overview]
Message-ID: <20180816095941.5acf7dbe@xeon-e3> (raw)
In-Reply-To: <C7B533E5-6755-4F52-BA8E-21E5022EF581@intel.com>
On Thu, 16 Aug 2018 16:34:12 +0000
"Wiles, Keith" <keith.wiles@intel.com> wrote:
> I looked at the Coding Guide in section 1.7.2 and it states
>
> 1.7.2. Definitions
> - The function type should be on a line by itself preceding the function.
> - The opening brace of the function body should be on a line by itself.
>
> static char *
> function(int a1, int a2, float fl, int a4)
> {
Really, I thought in general DPDK followed Linux kernel style.
Making little exceptions like this is a nuisance.
next prev parent reply other threads:[~2018-08-16 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 15:31 [PATCH 0/2] eal: hexcump trivial changes Stephen Hemminger
2018-08-16 15:31 ` [PATCH 1/2] hexdump: whitespace cleanup Stephen Hemminger
2018-08-16 16:34 ` Wiles, Keith
2018-08-16 16:59 ` Stephen Hemminger [this message]
2018-08-16 16:35 ` Wiles, Keith
2018-08-16 15:31 ` [PATCH 2/2] hexdump: align output of string Stephen Hemminger
2018-08-16 15:50 ` Stephen Hemminger
2018-10-24 23:40 ` [PATCH 0/2] eal: hexcump trivial changes Thomas Monjalon
2019-04-02 15:23 ` [PATCH v2 0/2] eal: hexdump cleanups Stephen Hemminger
2019-04-02 15:23 ` [PATCH v2 1/2] hexdump: whitespace cleanup Stephen Hemminger
2019-04-02 15:23 ` [PATCH v2 2/2] hexdump: align output of string Stephen Hemminger
2019-04-03 16:36 ` [PATCH v2 0/2] eal: hexdump cleanups Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816095941.5acf7dbe@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.