From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd
Date: Thu, 16 Aug 2018 13:53:47 +0200 [thread overview]
Message-ID: <20180816115347.GC13716@dell5510> (raw)
In-Reply-To: <1e9e35dc-3f2f-0eb7-59aa-8f600bdf949f@oracle.com>
Hi,
> On 08/16/2018 01:59 PM, Cyril Hrubis wrote:
> > Hi...
> > I do not like much that we change the behavir based on tst_test content.
> > Maybe it would be cleaner to define a tst_check_driver(const char *name),
> > then we can do the loop over tst_test->needs_drivers in the tst_test.c
> > library and loop over argv in the shell helper.
+1 it makes sense.
> Hi Cyril,
> OK, will send the 2nd version.
BTW it'd be nice to have support to load module with parameters.
> Thanks,
> Alexey
Kind regards,
Petr
next prev parent reply other threads:[~2018-08-16 11:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 15:23 [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Alexey Kodanev
2018-08-09 15:23 ` [LTP] [PATCH RFC 2/4] lib/tst_test.sh: add TST_NEEDS_DRIVERS parameter Alexey Kodanev
2018-08-14 17:11 ` Petr Vorel
2018-08-16 8:54 ` Petr Vorel
2018-08-16 11:49 ` Alexey Kodanev
2018-08-09 15:23 ` [LTP] [PATCH RFC 3/4] lib/tst_test.sh: add TST_RTNL_CHK() helper function Alexey Kodanev
2018-08-14 18:39 ` Petr Vorel
2018-08-09 15:23 ` [LTP] [PATCH RFC 4/4] network/ipsec: replace ipsec_try() with TST_RTNL_CHK() Alexey Kodanev
2018-08-14 18:40 ` Petr Vorel
2018-08-16 11:16 ` [LTP] [RFC PATCH 2/2] netstress: Update help for -m behavior Petr Vorel
2018-08-16 12:01 ` Alexey Kodanev
2018-08-16 11:42 ` [LTP] [PATCH v2 1/1] network/route: Rewrite route-change-dst into new API Petr Vorel
2018-08-14 17:06 ` [LTP] [PATCH RFC 1/4] lib/tst_test.c: add 'needs_drivers' option with tst_check_drivers cmd Petr Vorel
2018-08-15 15:22 ` Alexey Kodanev
2018-08-16 10:59 ` Cyril Hrubis
2018-08-16 11:54 ` Alexey Kodanev
2018-08-16 11:53 ` Petr Vorel [this message]
2018-08-16 12:21 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816115347.GC13716@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.