All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS
Date: Thu, 16 Aug 2018 20:25:44 +0200	[thread overview]
Message-ID: <20180816182544.GA20904@x230> (raw)
In-Reply-To: <CAModR+UmByc96RR1_vR0nVc0HJAjzLq9j8Z+Rea=WE9AD9g1nQ@mail.gmail.com>

Hi Igor,

First, thanks for the reviews!

On Thu, Aug 16, 2018 at 11:38:18AM +0300, Igor Opaniuk wrote:
> Hi Eugeniu,
> 
> Why not keep all dependencies on the same line in this case? Simply:
> depends LIBAVB && FASTBOOT && PARTITION_UUIDS

I guess it's a matter of personal preference (but maybe not entirely).
Let's say one needs to replace "depends on PARTITION_UUIDS" with
"select PARTITION_UUIDS" due to e.g. a circular dependency detected
by Kconfig at some point. For me below two lines:

- depends on PARTITION_UUIDS
+ select PARTITION_UUIDS

look more readable and are easier to review than:

- depends LIBAVB && FASTBOOT && PARTITION_UUIDS
+ depends LIBAVB && FASTBOOT
+ select PARTITION_UUIDS

I still can update the patch. Just let me know.

> 
> Regards,
> Igor

Best regards,
Eugeniu.

  reply	other threads:[~2018-08-16 18:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14  0:43 [U-Boot] [PATCH 1/7] libavb: Handle wrong hashtree_error_mode in avb_append_options() Eugeniu Rosca
2018-08-14  0:43 ` [U-Boot] [PATCH 2/7] common: avb_verify: Fix invalid 'for' loop condition Eugeniu Rosca
2018-08-16  8:34   ` Igor Opaniuk
2018-08-24 20:09   ` [U-Boot] [U-Boot, " Tom Rini
2018-08-14  0:43 ` [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS Eugeniu Rosca
2018-08-16  8:38   ` Igor Opaniuk
2018-08-16 18:25     ` Eugeniu Rosca [this message]
2018-08-17 10:33       ` Igor Opaniuk
2018-08-24 20:09   ` [U-Boot] [U-Boot, " Tom Rini
2018-08-14  0:43 ` [U-Boot] [PATCH 4/7] common: avb_verify: Make local data static Eugeniu Rosca
2018-08-16  9:07   ` Igor Opaniuk
2018-08-16 18:34     ` Eugeniu Rosca
2018-08-24 20:09   ` [U-Boot] [U-Boot, " Tom Rini
2018-08-14  0:43 ` [U-Boot] [PATCH 5/7] common: avb_verify: Fix memory leaks Eugeniu Rosca
2018-08-16  9:18   ` Igor Opaniuk
2018-08-24 20:09   ` [U-Boot] [U-Boot,5/7] " Tom Rini
2018-08-14  0:43 ` [U-Boot] [PATCH 6/7] common: avb_verify: Fix never-occurring avb_free(ops_data) Eugeniu Rosca
2018-08-16  7:09   ` Igor Opaniuk
2018-08-24 20:09   ` [U-Boot] [U-Boot, " Tom Rini
2018-08-14  0:43 ` [U-Boot] [PATCH 7/7] common: avb_verify: Fix division by zero in mmc_byte_io() Eugeniu Rosca
2018-08-16  7:10   ` Igor Opaniuk
2018-08-24 20:09   ` [U-Boot] [U-Boot, " Tom Rini
2018-08-16  8:34 ` [U-Boot] [PATCH 1/7] libavb: Handle wrong hashtree_error_mode in avb_append_options() Igor Opaniuk
2018-08-24 20:09 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180816182544.GA20904@x230 \
    --to=roscaeugeniu@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.