From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/6] nvme-ana-log: fixup compiler warning in show_ana_log()
Date: Fri, 17 Aug 2018 10:09:24 +0200 [thread overview]
Message-ID: <20180817080924.GA13230@lst.de> (raw)
In-Reply-To: <20180817072908.56784-2-hare@suse.de>
On Fri, Aug 17, 2018@09:29:03AM +0200, Hannes Reinecke wrote:
> Add the correct type cast to keep the compiler happy.
>
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> ---
> nvme-print.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/nvme-print.c b/nvme-print.c
> index e0da949..8a604c5 100644
> --- a/nvme-print.c
> +++ b/nvme-print.c
> @@ -1460,7 +1460,8 @@ void show_ana_log(struct nvme_ana_rsp_hdr *ana_log, const char *devname)
> offset += sizeof(*desc);
> printf("grpid : %u\n", le32_to_cpu(desc->grpid));
> printf("nnsids : %u\n", le32_to_cpu(desc->nnsids));
> - printf("chgcnt : %"PRIu64"\n", le64_to_cpu(desc->chgcnt));
> + printf("chgcnt : %"PRIu64"\n",
> + (uint64_t)le64_to_cpu(desc->chgcnt));
Wouldn't it be easier to just use %llu as the printf specified, given
that u64/__u64 are always and unsigned long long?
next prev parent reply other threads:[~2018-08-17 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 7:29 [PATCH 0/6] nvme-cli fixes and ANA updates Hannes Reinecke
2018-08-17 7:29 ` [PATCH 1/6] nvme-ana-log: fixup compiler warning in show_ana_log() Hannes Reinecke
2018-08-17 8:09 ` Christoph Hellwig [this message]
2018-08-17 21:44 ` Chaitanya Kulkarni
2018-08-17 21:55 ` Keith Busch
2018-08-17 7:29 ` [PATCH 2/6] nvme-vendor: fixup c99 declaration in huawei plugin Hannes Reinecke
2018-08-17 8:09 ` Christoph Hellwig
2018-08-17 21:56 ` Keith Busch
2018-08-17 7:29 ` [PATCH 3/6] nvme-discover: sanitize options Hannes Reinecke
2018-08-17 8:10 ` Christoph Hellwig
2018-08-17 7:29 ` [PATCH 4/6] nvme-discover: Retry discovery log if the generation counter changes Hannes Reinecke
2018-08-17 8:11 ` Christoph Hellwig
2018-08-17 10:06 ` Hannes Reinecke
2018-08-17 7:29 ` [PATCH 5/6] nvme-list-subsys: Print PCIe controller address Hannes Reinecke
2018-08-17 8:12 ` Christoph Hellwig
2018-08-17 10:06 ` Hannes Reinecke
2018-08-17 7:29 ` [PATCH 6/6] nvme-list-subsys: Add device name argument and print out ANA state Hannes Reinecke
2018-08-17 8:12 ` Christoph Hellwig
2018-08-17 22:14 ` Chaitanya Kulkarni
2018-08-17 21:58 ` [PATCH 0/6] nvme-cli fixes and ANA updates Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817080924.GA13230@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.