All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Pipe key broken on US keyboards
Date: Fri, 17 Aug 2018 09:56:56 +0100	[thread overview]
Message-ID: <20180817085656.GA11124@redhat.com> (raw)
In-Reply-To: <83320617-5d60-fe71-3ef5-8ac7c384a3b1@ubuntu.com>

On Thu, Aug 16, 2018 at 03:44:54PM -0400, Phillip Susi wrote:
> On 8/16/2018 1:27 PM, Daniel P. Berrangé wrote:
> > Did you actually 'git bisect' to that commit, or is that just a guess ?
> 
> No, I haven't actually tried to build it from sources myself yet so I
> just found the source file that handles the keyboard, saw a bunch of
> scancode translation stuff in it, did a git log on that file and that
> first commit sticks out like a sore thumb; it changes the way scancodes
> are translated in a big way and the timing of it seems about right.  The
> other commits talk about fixing specific key codes that are unrelated to
> pipe, and it looks like this commit threw out the code those commits
> touched anyhow and refactored the whole thing.

Oh one other thing, is whether your QEMU process has an explicit keymap
configured (this is the -k arg to QEMU), as when that it set, it
completely changes the way keyboard input is handled in VNC. That code
has also been massively refactored recently.

> > If not, could you 'git bisect' to confirm the actual commit, as there
> > have been lots of changes in this area.
> 
> I'll try.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2018-08-17  8:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 17:11 [Qemu-devel] Pipe key broken on US keyboards Phillip Susi
2018-08-16 17:27 ` Daniel P. Berrangé
2018-08-16 19:44   ` Phillip Susi
2018-08-17  8:56     ` Daniel P. Berrangé [this message]
2018-08-17 12:44       ` Phillip Susi
2018-08-17 12:58         ` Daniel P. Berrangé
2018-08-17 13:10           ` Phillip Susi
2018-08-17 13:12             ` Daniel P. Berrangé
2018-08-17 13:23               ` Phillip Susi
2018-08-17 14:36               ` Phillip Susi
2018-08-17 14:44                 ` Daniel P. Berrangé
2018-08-17 14:55                   ` Phillip Susi
2018-08-17 15:06                   ` Daniel P. Berrangé
2018-08-17 12:56 ` Daniel P. Berrangé
2018-08-17 15:05 ` Daniel P. Berrangé
2018-08-17 15:16   ` Phillip Susi
2018-08-17 15:51     ` Daniel P. Berrangé
2018-08-21 19:35       ` Phillip Susi
2018-08-20  8:43     ` Gerd Hoffmann
2018-08-20 14:23       ` Phillip Susi
2018-08-20 15:07         ` Christian Ehrhardt
2018-08-20 19:51           ` Phillip Susi
2018-08-20 20:04             ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817085656.GA11124@redhat.com \
    --to=berrange@redhat.com \
    --cc=psusi@ubuntu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.