From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dahdi-tools: fix dependencies comment condition
Date: Fri, 17 Aug 2018 11:26:48 +0200 [thread overview]
Message-ID: <20180817092648.GG2556@scaer> (raw)
In-Reply-To: <bcc4fba3f0a19c97f2361a8924defc43716966cc.1534496720.git.baruch@tkos.co.il>
Baruch, All,
On 2018-08-17 12:05 +0300, Baruch Siach spake thusly:
> The threads dependency comment is unrelated to the Linux kernel
> dependency.
But at the same time, if the kernel is not enabled, do we want to
display the comment?
However, this is indeed not like the other cases, where we have a single
comment, like aufs-utils, gst-plugin-x170, on2-8170-libs, sysdig, or,
with a slight difference, xdriver_xf86-video-imx.
So, if we want to make it more similar to the others, and to make it
conform to the manual (17.2.5 Dependencies on a Linux kernel built by
buildroot):
comment "dahdi-tools needs a toolchain w/ threads and a Linux kernel to be built"
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LINUX_KERNEL
and get rid of the second comment altogether.
Regards,
Yann E. MORIN.
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/dahdi-tools/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/dahdi-tools/Config.in b/package/dahdi-tools/Config.in
> index 39042df04134..625d17f216e3 100644
> --- a/package/dahdi-tools/Config.in
> +++ b/package/dahdi-tools/Config.in
> @@ -17,7 +17,7 @@ config BR2_PACKAGE_DAHDI_TOOLS
>
> # Two comments, otherwise it may not fit in menuconfig for narrow terminals
> comment "dahdi-tools needs a toolchain w/ threads"
> - depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LINUX_KERNEL
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> comment "dahdi-tools needs a Linux kernel to be built"
> depends on !BR2_LINUX_KERNEL
> --
> 2.18.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-08-17 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 9:05 [Buildroot] [PATCH] dahdi-tools: fix dependencies comment condition Baruch Siach
2018-08-17 9:26 ` Yann E. MORIN [this message]
2018-08-17 9:33 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817092648.GG2556@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.