From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqbMq-000703-0s for qemu-devel@nongnu.org; Fri, 17 Aug 2018 05:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqbMm-00083S-52 for qemu-devel@nongnu.org; Fri, 17 Aug 2018 05:48:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37188 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fqbMm-00083A-01 for qemu-devel@nongnu.org; Fri, 17 Aug 2018 05:48:24 -0400 Date: Fri, 17 Aug 2018 10:48:19 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180817094819.GE11124@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1534491213-24748-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1534491213-24748-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= , Paolo Bonzini , Gerd Hoffmann On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote: > While adding the object_initialize_child() function, Paolo suggested > to rename the similar object_new_with_props() function accordingly: > > http://marc.info/?i=e034610d-9a1d-a8a5-ee92-b2e3f0ba2891@redhat.com > > This way it is more obvious that this function creates a new object > as a child of another object. I'd expect 'object_new_with_child' to be the same as 'object_new', but with only 'parent' & 'id' args added, which isn't the case here. If we want the full & consistent design then we should have object_new(typename) object_new_with_child(typename, parent, id) object_new_props(typename, ...) object_new_propv(typename, va_arg props) object_new_with_child_props(typename, parent, id, ...) object_new_with_child_propv(typename, parent, id, va_arg props) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|