From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 17 Aug 2018 08:46:36 -0400 Subject: [U-Boot] [PATCH] configs: Migrate CONFIG_NR_DRAM_BANKS In-Reply-To: References: <1534468351-1820-1-git-send-email-trini@konsulko.com> Message-ID: <20180817124636.GI30947@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Aug 17, 2018 at 08:17:45AM +0200, Michal Simek wrote: > Hi Tom, > > On 17.8.2018 03:12, Tom Rini wrote: > > We have the following cases: > > - CONFIG_NR_DRAM_BANKS was defined, migrate normally > > - CONFIG_NR_DRAM_BANKS_MAX was defined and then used for > > CONFIG_NR_DRAM_BANKS after a check, just migrate it over now. > > - CONFIG_NR_DRAM_BANKS was very oddly defined on p2771-0000-* (to 1024 + > > 2), set this to 8. > > > > Signed-off-by: Tom Rini > > --- > > zynq-common.h contained > > #ifndef CONFIG_NR_DRAM_BANKS > # define CONFIG_NR_DRAM_BANKS 1 > #endif > > that's why I expect you wanted to use default setup which is 4. > We had this code there only for handling use case with additional bank > connected to programmable logic which is unused now. > Anyway will be the best to use 1 for all current zynq boards. > > Also the similar thing happened with zynqmp boards where we had default > setup 2 and it was changed to 4. > > #ifndef CONFIG_NR_DRAM_BANKS > # define CONFIG_NR_DRAM_BANKS 2 > #endif > > Code was there to handle mini configurations which use 1 bank all the time. > > I checked microblaze and zynqmp-mini and zynqmp-r5 and they are fine. OK, sorry about that. But, a question. What happens / what to we lose / get wrong by having them be set to 4 (or say 8 on the ARMv8 parts) ? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: