diff for duplicates of <20180817125228.25cf47ce@xeon-e3> diff --git a/a/1.txt b/N1/1.txt index 02a4e48..e7bca37 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,13 @@ On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) Mikulas Patocka <mpatocka@redhat.com> wrote: -> =================================> --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 18:11:00.000000000 +0200 +> =================================================================== +> --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 18:11:00.000000000 +0200 > +++ linux-stable/drivers/net/ethernet/sun/sunhme.c 2018-08-13 22:01:08.000000000 +0200 > @@ -572,21 +572,21 @@ static void display_link_mode(struct hap > { > printk(KERN_INFO "%s: Link is up using ", hp->dev->name); -> if (hp->tcvr_type = external) +> if (hp->tcvr_type == external) > - printk("external "); > + pr_cont("external "); > else @@ -36,6 +37,6 @@ Why not just use a single netdev_info (or drop the useless message altogether). I.e netdev_info(hp->dev, "Link is up using %s transceiver at %dMb/s %s Duplex\n", - (hp->tcvr->type = external) ? "external" : "internal", + (hp->tcvr->type == external) ? "external" : "internal", (hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) ? 100 : 10, (hw->sw_lpa & (LPA_100FULL | LPA_10FULL)) ? "Full" : "Half")); diff --git a/a/content_digest b/N1/content_digest index 31bb11e..d43031b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0alpine.LRH.2.02.1808171510510.31883@file01.intranet.prod.int.rdu2.redhat.com\0" "From\0Stephen Hemminger <stephen@networkplumber.org>\0" "Subject\0Re: [PATCH] sunhme: convert printk to pr_cont\0" - "Date\0Fri, 17 Aug 2018 19:52:28 +0000\0" + "Date\0Fri, 17 Aug 2018 12:52:28 -0700\0" "To\0Mikulas Patocka <mpatocka@redhat.com>\0" "Cc\0David S. Miller <davem@davemloft.net>" sparclinux@vger.kernel.org @@ -11,12 +11,13 @@ "On Fri, 17 Aug 2018 15:12:22 -0400 (EDT)\n" "Mikulas Patocka <mpatocka@redhat.com> wrote:\n" "\n" - "> =================================> --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c\t2018-04-20 18:11:00.000000000 +0200\n" + "> ===================================================================\n" + "> --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c\t2018-04-20 18:11:00.000000000 +0200\n" "> +++ linux-stable/drivers/net/ethernet/sun/sunhme.c\t2018-08-13 22:01:08.000000000 +0200\n" "> @@ -572,21 +572,21 @@ static void display_link_mode(struct hap\n" "> {\n" "> \tprintk(KERN_INFO \"%s: Link is up using \", hp->dev->name);\n" - "> \tif (hp->tcvr_type = external)\n" + "> \tif (hp->tcvr_type == external)\n" "> -\t\tprintk(\"external \");\n" "> +\t\tpr_cont(\"external \");\n" "> \telse\n" @@ -46,8 +47,8 @@ "\n" "I.e\n" "\tnetdev_info(hp->dev, \"Link is up using %s transceiver at %dMb/s %s Duplex\\n\",\n" - "\t\t(hp->tcvr->type = external) ? \"external\" : \"internal\",\n" + "\t\t(hp->tcvr->type == external) ? \"external\" : \"internal\",\n" "\t\t(hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) ? 100 : 10,\n" "\t\t(hw->sw_lpa & (LPA_100FULL | LPA_10FULL)) ? \"Full\" : \"Half\"));" -f1da06b1e318f2b520ff98d061fa8216d81e8c657f99e9d567a9948afb9b934e +365a77baed3a89f9ddd83b48768327d7381b15702d642a0c8609cd561793684e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.