From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Date: Fri, 17 Aug 2018 19:52:28 +0000 Subject: Re: [PATCH] sunhme: convert printk to pr_cont Message-Id: <20180817125228.25cf47ce@xeon-e3> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka Cc: "David S. Miller" , sparclinux@vger.kernel.org, netdev@vger.kernel.org On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) Mikulas Patocka wrote: > =================================> --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 18:11:00.000000000 +0200 > +++ linux-stable/drivers/net/ethernet/sun/sunhme.c 2018-08-13 22:01:08.000000000 +0200 > @@ -572,21 +572,21 @@ static void display_link_mode(struct hap > { > printk(KERN_INFO "%s: Link is up using ", hp->dev->name); > if (hp->tcvr_type = external) > - printk("external "); > + pr_cont("external "); > else > - printk("internal "); > - printk("transceiver at "); > + pr_cont("internal "); > + pr_cont("transceiver at "); > hp->sw_lpa = happy_meal_tcvr_read(hp, tregs, MII_LPA); > if (hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) { > if (hp->sw_lpa & LPA_100FULL) > - printk("100Mb/s, Full Duplex.\n"); > + pr_cont("100Mb/s, Full Duplex.\n"); > else > - printk("100Mb/s, Half Duplex.\n"); > + pr_cont("100Mb/s, Half Duplex.\n"); > } else { > if (hp->sw_lpa & LPA_10FULL) > - printk("10Mb/s, Full Duplex.\n"); > + pr_cont("10Mb/s, Full Duplex.\n"); > else > - printk("10Mb/s, Half Duplex.\n"); > + pr_cont("10Mb/s, Half Duplex.\n"); > } > } Why not just use a single netdev_info (or drop the useless message altogether). I.e netdev_info(hp->dev, "Link is up using %s transceiver at %dMb/s %s Duplex\n", (hp->tcvr->type = external) ? "external" : "internal", (hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) ? 100 : 10, (hw->sw_lpa & (LPA_100FULL | LPA_10FULL)) ? "Full" : "Half")); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] sunhme: convert printk to pr_cont Date: Fri, 17 Aug 2018 12:52:28 -0700 Message-ID: <20180817125228.25cf47ce@xeon-e3> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , sparclinux@vger.kernel.org, netdev@vger.kernel.org To: Mikulas Patocka Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:41607 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbeHQW5N (ORCPT ); Fri, 17 Aug 2018 18:57:13 -0400 Received: by mail-pg1-f196.google.com with SMTP id s15-v6so1256112pgv.8 for ; Fri, 17 Aug 2018 12:52:31 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) Mikulas Patocka wrote: > =================================================================== > --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 18:11:00.000000000 +0200 > +++ linux-stable/drivers/net/ethernet/sun/sunhme.c 2018-08-13 22:01:08.000000000 +0200 > @@ -572,21 +572,21 @@ static void display_link_mode(struct hap > { > printk(KERN_INFO "%s: Link is up using ", hp->dev->name); > if (hp->tcvr_type == external) > - printk("external "); > + pr_cont("external "); > else > - printk("internal "); > - printk("transceiver at "); > + pr_cont("internal "); > + pr_cont("transceiver at "); > hp->sw_lpa = happy_meal_tcvr_read(hp, tregs, MII_LPA); > if (hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) { > if (hp->sw_lpa & LPA_100FULL) > - printk("100Mb/s, Full Duplex.\n"); > + pr_cont("100Mb/s, Full Duplex.\n"); > else > - printk("100Mb/s, Half Duplex.\n"); > + pr_cont("100Mb/s, Half Duplex.\n"); > } else { > if (hp->sw_lpa & LPA_10FULL) > - printk("10Mb/s, Full Duplex.\n"); > + pr_cont("10Mb/s, Full Duplex.\n"); > else > - printk("10Mb/s, Half Duplex.\n"); > + pr_cont("10Mb/s, Half Duplex.\n"); > } > } Why not just use a single netdev_info (or drop the useless message altogether). I.e netdev_info(hp->dev, "Link is up using %s transceiver at %dMb/s %s Duplex\n", (hp->tcvr->type == external) ? "external" : "internal", (hp->sw_lpa & (LPA_100HALF | LPA_100FULL)) ? 100 : 10, (hw->sw_lpa & (LPA_100FULL | LPA_10FULL)) ? "Full" : "Half"));