From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ganesh Goudar <ganeshgr@chelsio.com>
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts
Date: Fri, 17 Aug 2018 19:58:41 +0100 [thread overview]
Message-ID: <20180817185841.GF6515@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180817180949.GE6515@ZenIV.linux.org.uk>
On Fri, Aug 17, 2018 at 07:09:49PM +0100, Al Viro wrote:
> Re that code - are you sure it doesn't need le64_to_cpu(*src)? Because from what
> I understand about PCI (which matches just fine to the comments in the same driver),
> you probably do need that. Again, the only real way to find out is to test on
> big-endian host...
BTW, would that, by any chance, be an open-coded
_iowrite64_copy(dst, src, EQ_UNIT/sizeof(u64))
next prev parent reply other threads:[~2018-08-17 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 17:22 [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts Al Viro
2018-08-06 12:15 ` Rahul Lakkireddy
2018-08-14 21:25 ` Al Viro
2018-08-17 13:05 ` Ganesh Goudar
2018-08-17 15:43 ` Al Viro
2018-08-17 16:34 ` David Miller
2018-08-17 18:09 ` Al Viro
2018-08-17 18:58 ` Al Viro [this message]
2018-08-17 18:59 ` Al Viro
2018-08-17 19:44 ` Al Viro
2018-08-22 10:29 ` Ganesh Goudar
2018-08-07 19:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817185841.GF6515@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.