Re: [PATCH] drm/i915: Do not redefine the has_csr parameter.

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Aug 17, 2018 at 09:04:24PM +0300, Imre Deak wrote:
> On Fri, Aug 17, 2018 at 10:33:30AM -0700, Anusha Srivatsa wrote:
> > Let us reuse the already defined has_csr check and not
> > redefine it.
> 
> The main difference is that in effect this will flip .has_csr to 1
> (via GEN9_FEATURES which GEN11_FEATURES pulls in).

amended when pushing

> 
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=107382
> > 
> > Suggested-by: Imre Deak <imre.deak@intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>

pushed to dinq. thanks for patch and review

> 
> > ---
> >  drivers/gpu/drm/i915/i915_pci.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> > index e931b48..d6f7b9f 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -600,7 +600,6 @@ static const struct intel_device_info intel_cannonlake_info = {
> >  	GEN10_FEATURES, \
> >  	GEN(11), \
> >  	.ddb_size = 2048, \
> > -	.has_csr = 0, \
> >  	.has_logical_ring_elsq = 1
> >  
> >  static const struct intel_device_info intel_icelake_11_info = {
> > -- 
> > 2.7.4
> > 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx