Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

[Yuval Shaia <yuval.shaia@oracle.com>]

On Sat, Aug 18, 2018 at 04:46:29PM +0300, Marcel Apfelbaum wrote:
> Hi Yuval,
> 
> On 08/14/2018 01:00 PM, Yuval Shaia wrote:
> > Function create_ah might return NULL, let's exit with an error.
> > 
> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> > ---
> >   hw/rdma/rdma_backend.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> > index 35726bda2e..59d02eb567 100644
> > --- a/hw/rdma/rdma_backend.c
> > +++ b/hw/rdma/rdma_backend.c
> > @@ -402,6 +402,10 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev,
> >       if (qp_type == IBV_QPT_UD) {
> >           wr.wr.ud.ah = create_ah(backend_dev, qp->ibpd,
> >                                   backend_dev->backend_gid_idx, dgid);
> > +        if (!wr.wr.ud.ah) {
> > +            comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_FAIL_BACKEND, ctx, 0);
> 
> comp_handler takes 3 arguments, but here you pass 4, so the compilation
> fails.

Right, please ignore this patch.
I will send it with a different patch-set which is still under work.

> 
> Thanks,
> Marcel
> 
> > +            goto out_dealloc_cqe_ctx;
> > +        }
> >           wr.wr.ud.remote_qpn = dqpn;
> >           wr.wr.ud.remote_qkey = dqkey;
> >       }
>