From: Dmitry Osipenko <digetx@gmail.com>
To: Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>
Cc: iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 16/19] iommu/tegra: gart: Prepend error/debug messages with "GART:"
Date: Sat, 18 Aug 2018 18:54:27 +0300 [thread overview]
Message-ID: <20180818155430.5586-17-digetx@gmail.com> (raw)
In-Reply-To: <20180818155430.5586-1-digetx@gmail.com>
GART became a part of Memory Controller, hence now the drivers device
is Memory Controller and not GART. As a result all printed messages are
prepended with the "tegra-mc 7000f000.memory-controller:", so let's
prepend GART's messages with "GART:" in order to differentiate them
from the MC.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/iommu/tegra-gart.c | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index d019ae8ecfc9..284cddf90888 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -96,7 +96,7 @@ static inline void gart_set_pte(struct gart_device *gart,
writel(offs, gart->regs + GART_ENTRY_ADDR);
writel(pte, gart->regs + GART_ENTRY_DATA);
- dev_dbg(gart->dev, "%s %08lx:%08x\n",
+ dev_dbg(gart->dev, "GART: %s %08lx:%08x\n",
pte ? "map" : "unmap", offs, pte & GART_PAGE_MASK);
}
@@ -134,7 +134,7 @@ static void gart_dump_table(struct gart_device *gart)
pte = gart_read_pte(gart, iova);
- dev_dbg(gart->dev, "%s %08lx:%08lx\n",
+ dev_dbg(gart->dev, "GART: %s %08lx:%08lx\n",
(GART_ENTRY_PHYS_ADDR_VALID & pte) ? "v" : " ",
iova, pte & GART_PAGE_MASK);
}
@@ -179,21 +179,22 @@ static int gart_iommu_attach_dev(struct iommu_domain *domain,
spin_lock(&gart->client_lock);
list_for_each_entry(c, &gart->client, list) {
if (c->dev == dev) {
- dev_err(gart->dev,
- "%s is already attached\n", dev_name(dev));
+ dev_err(gart->dev, "GART: %s is already attached\n",
+ dev_name(dev));
err = -EINVAL;
goto fail;
}
}
if (gart->active_domain && gart->active_domain != domain) {
- dev_err(gart->dev, "Only one domain can be active at a time\n");
+ dev_err(gart->dev,
+ "GART: Only one domain can be active at a time\n");
err = -EINVAL;
goto fail;
}
gart->active_domain = domain;
list_add(&client->list, &gart->client);
spin_unlock(&gart->client_lock);
- dev_dbg(gart->dev, "Attached %s\n", dev_name(dev));
+ dev_dbg(gart->dev, "GART: Attached %s\n", dev_name(dev));
return 0;
fail:
@@ -215,12 +216,14 @@ static void __gart_iommu_detach_dev(struct iommu_domain *domain,
kfree(c);
if (list_empty(&gart->client))
gart->active_domain = NULL;
- dev_dbg(gart->dev, "Detached %s\n", dev_name(dev));
+ dev_dbg(gart->dev, "GART: Detached %s\n",
+ dev_name(dev));
return;
}
}
- dev_err(gart->dev, "Couldn't find %s to detach\n", dev_name(dev));
+ dev_err(gart->dev, "GART: Couldn't find %s to detach\n",
+ dev_name(dev));
}
static void gart_iommu_detach_dev(struct iommu_domain *domain,
@@ -293,7 +296,7 @@ static int gart_iommu_map(struct iommu_domain *domain, unsigned long iova,
spin_lock_irqsave(&gart->pte_lock, flags);
pfn = __phys_to_pfn(pa);
if (!pfn_valid(pfn)) {
- dev_err(gart->dev, "Invalid page: %pa\n", &pa);
+ dev_err(gart->dev, "GART: Invalid page: %pa\n", &pa);
spin_unlock_irqrestore(&gart->pte_lock, flags);
return -EINVAL;
}
@@ -301,7 +304,7 @@ static int gart_iommu_map(struct iommu_domain *domain, unsigned long iova,
pte = gart_read_pte(gart, iova);
if (pte & GART_ENTRY_PHYS_ADDR_VALID) {
spin_unlock_irqrestore(&gart->pte_lock, flags);
- dev_err(gart->dev, "Page entry is in-use\n");
+ dev_err(gart->dev, "GART: Page entry is in-use\n");
return -EBUSY;
}
}
@@ -344,7 +347,7 @@ static phys_addr_t gart_iommu_iova_to_phys(struct iommu_domain *domain,
pa = (pte & GART_PAGE_MASK);
if (!pfn_valid(__phys_to_pfn(pa))) {
- dev_err(gart->dev, "No entry for %08llx:%pa\n",
+ dev_err(gart->dev, "GART: No entry for %08llx:%pa\n",
(unsigned long long)iova, &pa);
gart_dump_table(gart);
return -EINVAL;
@@ -455,19 +458,17 @@ struct gart_device *tegra_gart_probe(struct device *dev,
res_remap = platform_get_resource(to_platform_device(dev),
IORESOURCE_MEM, 1);
if (!res_remap) {
- dev_err(dev, "GART memory aperture expected\n");
+ dev_err(dev, "GART: Memory aperture resource unavailable\n");
return ERR_PTR(-ENXIO);
}
gart = kzalloc(sizeof(*gart), GFP_KERNEL);
- if (!gart) {
- dev_err(dev, "failed to allocate gart_device\n");
+ if (!gart)
return ERR_PTR(-ENOMEM);
- }
ret = iommu_device_sysfs_add(&gart->iommu, dev, NULL, "gart");
if (ret) {
- dev_err(dev, "Failed to register IOMMU in sysfs\n");
+ dev_err(dev, "GART: Failed to register IOMMU sysfs\n");
goto free_gart;
}
@@ -476,7 +477,7 @@ struct gart_device *tegra_gart_probe(struct device *dev,
ret = iommu_device_register(&gart->iommu);
if (ret) {
- dev_err(dev, "Failed to register IOMMU\n");
+ dev_err(dev, "GART: Failed to register IOMMU\n");
goto remove_sysfs;
}
@@ -491,7 +492,6 @@ struct gart_device *tegra_gart_probe(struct device *dev,
gart->savedata = vmalloc(array_size(sizeof(u32), gart->page_count));
if (!gart->savedata) {
- dev_err(dev, "failed to allocate context save area\n");
ret = -ENOMEM;
goto unregister_iommu;
}
--
2.18.0
next prev parent reply other threads:[~2018-08-18 15:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 15:54 [PATCH v3 00/19] IOMMU: Tegra GART driver clean up and optimization Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 01/19] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 03/19] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 05/19] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
[not found] ` <20180818155430.5586-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-18 15:54 ` [PATCH v3 02/19] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 04/19] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 06/19] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko
2018-08-20 19:12 ` Rob Herring
2018-08-20 19:27 ` Dmitry Osipenko
2018-08-20 19:27 ` Dmitry Osipenko
[not found] ` <b46cac22-9b31-9aa7-7eca-4725156346bb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-20 19:35 ` Dmitry Osipenko
2018-08-20 19:35 ` Dmitry Osipenko
[not found] ` <4538309b-fcb3-73ee-04e3-6cefcedd376d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-28 10:47 ` Thierry Reding
2018-08-28 10:47 ` Thierry Reding
2018-08-28 13:09 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 07/19] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 08/19] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 09/19] memory: tegra: Adapt to Tegra20 device-tree binding changes Dmitry Osipenko
2018-09-03 21:06 ` Marcel Ziswiler
2018-09-04 8:56 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 10/19] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 11/19] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 12/19] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 13/19] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 14/19] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 15/19] iommu/tegra: gart: Don't use managed resources Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko [this message]
2018-08-18 15:54 ` [PATCH v3 17/19] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 18/19] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 19/19] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818155430.5586-17-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.