From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD
 callbacks for eth Tx adapter
Date: Sun, 19 Aug 2018 16:15:35 +0530
Message-ID: <20180819104534.GB11085@jerin>
References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com>
 <1534479652-80182-2-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: olivier.matz@6wind.com, dev@dpdk.org
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0082.outbound.protection.outlook.com [104.47.36.82])
 by dpdk.org (Postfix) with ESMTP id 8B5FC2C5
 for <dev@dpdk.org>; Sun, 19 Aug 2018 12:45:55 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1534479652-80182-2-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 17 Aug 2018 09:50:50 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>
> Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx
>  adapter
> X-Mailer: git-send-email 1.8.3.1
> 
> 
> The caps API allows the application to query if the transmit
> stage is implemented in the eventdev PMD or uses the common
> rte_service function. The PMD callbacks support the
> eventdev PMD implementation of the adapter.
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> +
>  static inline int
>  rte_event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues)
>  {
> @@ -1275,6 +1300,15 @@ int rte_event_dev_selftest(uint8_t dev_id)
>         return RTE_EVENT_MAX_DEVS;
>  }
> 
> @@ -1295,6 +1329,9 @@ struct rte_eventdev *
> 
>         eventdev = &rte_eventdevs[dev_id];
> 
> +       if (eventdev->txa_enqueue == NULL)

Is this check required, it will be always NULL. Right? if so,
Can't we write eventdev->txa_enqueue directly?

> +               eventdev->txa_enqueue = rte_event_tx_adapter_enqueue;
> +

With above changes,

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>