From: Aurelien Jarno <aurelien@aurel32.net>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH v2] sh4: fix use_icount with linux-user
Date: Sun, 19 Aug 2018 23:07:45 +0200 [thread overview]
Message-ID: <20180819210745.GA31328@aurel32.net> (raw)
In-Reply-To: <7cd759fa-8d2b-f63b-3bd9-75fe528373a8@vivier.eu>
On 2018-08-16 20:58, Laurent Vivier wrote:
> Le 11/08/2018 à 17:26, Richard Henderson a écrit :
> > On 08/11/2018 01:23 AM, Laurent Vivier wrote:
> >> This fixes java in a linux-user chroot:
> >> $ java --version
> >> qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion `use_icount' failed.
> >> qemu: uncaught target signal 6 (Aborted) - core dumped
> >> Aborted (core dumped)
> >>
> >> In gen_conditional_jump() in the GUSA_EXCLUSIVE part, we must reset
> >> base.is_jmp to DISAS_NEXT after the gen_goto_tb() as it is done in
> >> gen_delayed_conditional_jump() after the gen_jump().
> >>
> >> Bug: https://bugs.launchpad.net/qemu/+bug/1768246
> >> Fixes: 4834871bc95b67343248100e2a75ae0d287bc08b
> >> ("target/sh4: Convert to DisasJumpType")
> >> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> >> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> >> ---
> >>
> >> Notes:
> >> v2:
> >> don't revert the part of the original patch,
> >> but fixes the state problem in gen_conditional_jump()
> >
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
> Aurélien,
>
> do you agree if I push this patch through a linux-user pull request?
Yes, that's fine with me.
Thanks,
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2018-08-19 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 8:23 [Qemu-devel] [PATCH v2] sh4: fix use_icount with linux-user Laurent Vivier
2018-08-11 15:22 ` John Paul Adrian Glaubitz
2018-08-11 15:26 ` Richard Henderson
2018-08-16 18:58 ` Laurent Vivier
2018-08-19 21:07 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819210745.GA31328@aurel32.net \
--to=aurelien@aurel32.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.