From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v3 2/4] meson: change from global to per package cross-compilation.conf
Date: Sun, 19 Aug 2018 23:05:16 +0200 [thread overview]
Message-ID: <20180819230516.6f839351@windsurf> (raw)
In-Reply-To: <20180819214917.67c960a3@gmx.net>
Hello,
On Sun, 19 Aug 2018 21:49:17 +0200, Peter Seiderer wrote:
> Seems to be intentional, see mesonbuild/backend/backends.py#L542 ([1]):
>
> if not target.is_cross:
> # Compile args added from the env: CFLAGS/CXXFLAGS, etc. We want these
> # to override all the defaults, but not the per-target compile args.
> commands += self.environment.coredata.get_external_args(compiler.get_language())
>
> With the 'if not target.is_cross' added with this commit [2] fixing [3] which
> suggests adding CROSS_*FLAGS...
>
> Regards,
> Peter
>
> [1] https://github.com/mesonbuild/meson/blob/master/mesonbuild/backend/backends.py#L542
> [2] https://github.com/mesonbuild/meson/commit/b595cda4ed0ca699da3052a6bd30ba7d1dae1124
> [3] https://github.com/mesonbuild/meson/issues/1772
Meh. This is plain silly, and completely inconsistent with what all
other build systems do. The idea that CFLAGS should not be taken into
account when cross-compiling is really stupid, as is "Cross build
settings should come from the cross file and nowhere else".
But well, OK, let's go with your solution then. I would still like a
proper .conf file to be generated and move in usr/share/buildroot/,
like the CMake file.
Could you also complain in that bug report, to explain that really
CFLAGS should be supported ?
Thanks for the additional research!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-19 21:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 20:43 [Buildroot] [RFC v3 1/4] meson: bump version to 0.47.1 Peter Seiderer
2018-07-19 20:43 ` [Buildroot] [RFC v3 2/4] meson: change from global to per package cross-compilation.conf Peter Seiderer
2018-07-22 12:27 ` Eric Le Bihan
2018-08-16 11:57 ` Thomas Petazzoni
2018-08-18 23:15 ` Peter Seiderer
2018-08-19 9:22 ` Yann E. MORIN
2018-08-19 17:13 ` Peter Seiderer
2018-08-19 13:22 ` Thomas Petazzoni
2018-08-19 17:15 ` Peter Seiderer
2018-08-19 19:49 ` Peter Seiderer
2018-08-19 21:05 ` Thomas Petazzoni [this message]
2018-07-19 20:43 ` [Buildroot] [RFC v3 3/4] libdrm: change to meson build system Peter Seiderer
2018-07-22 12:28 ` Eric Le Bihan
2019-04-07 20:21 ` Thomas Petazzoni
2018-07-19 20:43 ` [Buildroot] [RFC v3 4/4] libinput: bump version to 1.11.0 and convert to meson build Peter Seiderer
2018-07-22 12:29 ` Eric Le Bihan
2019-04-07 20:20 ` Thomas Petazzoni
2018-07-22 12:21 ` [Buildroot] [RFC v3 1/4] meson: bump version to 0.47.1 Eric Le Bihan
2018-08-16 11:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180819230516.6f839351@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.