From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] oracle-mysql: fix hostname path
Date: Mon, 20 Aug 2018 20:21:13 +0200 [thread overview]
Message-ID: <20180820202113.0a70c493@windsurf> (raw)
In-Reply-To: <20180820111304.22933-2-chrismcc@gmail.com>
Hello Christopher,
On Mon, 20 Aug 2018 04:13:02 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
An empty commit log for such a change is really not good. What is
broken ? How does this fix what was broken ?
In general, a good rule: if your commit log is empty, something is
wrong.
So for this time, I've added a commit log and applied your patch to
master, see at
https://git.buildroot.org/buildroot/commit/?id=0bf656ead9801552f939217c5cc019fa24583b90
what I added. For your next contributions, I will now expect a
non-empty commit log actually explaining what the issue was, and how
the patch solves it.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-20 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 11:13 [Buildroot] [PATCH 0/3] oracle-mysql bugfix, security fix, and enhancement Christopher McCrory
2018-08-20 11:13 ` [Buildroot] [PATCH 1/3] oracle-mysql: fix hostname path Christopher McCrory
2018-08-20 18:21 ` Thomas Petazzoni [this message]
2018-08-20 11:13 ` [Buildroot] [PATCH 2/3] oracle-mysql: use group mysql, not nogroup Christopher McCrory
2018-08-20 18:21 ` Thomas Petazzoni
2018-08-20 11:13 ` [Buildroot] [PATCH 3/3] oracle-mysql: check for my.cnf before starting Christopher McCrory
2018-08-20 18:23 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820202113.0a70c493@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.