All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] boost: context needs C++11
Date: Mon, 20 Aug 2018 22:50:58 +0200	[thread overview]
Message-ID: <20180820225058.4d83d48f@windsurf> (raw)
In-Reply-To: <20180820165555.20492-2-fontaine.fabrice@gmail.com>

Hello,

On Mon, 20 Aug 2018 18:55:55 +0200, Fabrice Fontaine wrote:
> Without this flag, mutex is not always correctly detected with gcc 4.x
> or 5.x. As a result, boost_thread is wrongly selected by boost_context.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/fb046c04fe18bec973d120e4ab33971f32ba5769
>  - http://autobuild.buildroot.net/results/99f1a255b78a973faeb8bf3b94d78efc54426a8b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/boost/boost.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/boost/boost.mk b/package/boost/boost.mk
> index 14f6162003..a09dd3cf45 100644
> --- a/package/boost/boost.mk
> +++ b/package/boost/boost.mk
> @@ -61,6 +61,11 @@ else
>  BOOST_FLAGS += --without-icu
>  endif
>  
> +# boost-context needs C++11
> +ifeq ($(BR2_PACKAGE_BOOST_CONTEXT),y)
> +BOOST_TARGET_CXXFLAGS += -std=c++11
> +endif

I was about to apply, but... C++11 requires at least gcc 4.8 or 4.9
depending on the features being used, and I don't see any dependency on
a gcc version in the definition of BR2_PACKAGE_BOOST_CONTEXT. There are
also other Boost options that say they are related to C++11.

Don't we have a problem with gcc 4.7 or older compilers ?

https://git.buildroot.org/buildroot/tree/support/config-fragments/autobuild/powerpc-ctng_e500v2-linux-gnuspe.config
has a 4.7 compiler.

I'm not sure we have a gcc 4.6 compiler. Perhaps we should add that to
the autobuilders.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-20 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 16:55 [Buildroot] [PATCH 1/2] boost: revert b20c5ca3b8c5b180a6ee87556d0c87d474e86cde Fabrice Fontaine
2018-08-20 16:55 ` [Buildroot] [PATCH 2/2] boost: context needs C++11 Fabrice Fontaine
2018-08-20 20:50   ` Thomas Petazzoni [this message]
2018-08-20 21:01     ` Bernd Kuhls
2018-08-20 21:33     ` Fabrice Fontaine
2018-08-20 21:37       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180820225058.4d83d48f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.