From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Tue, 21 Aug 2018 11:08:25 +0200 Subject: [PATCH v4 09/14] irqchip/irq-mvebu-icu: add support for System Error Interrupts (SEI) In-Reply-To: References: <20180705124011.7661-1-miquel.raynal@bootlin.com> <20180705124011.7661-10-miquel.raynal@bootlin.com> Message-ID: <20180821110825.2fbec982@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marc, I'm fine with the rest of the comments, please find just one last question below. [...] > > @@ -133,12 +164,36 @@ mvebu_icu_irq_domain_translate(struct irq_domain *d, struct irq_fwspec *fwspec, > > return -EINVAL; > > } > > > > - /* Mask the type to prevent wrong DT configuration */ > > - *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK; > > + /* > > + * The ICU receives level-interrupts. MSI SEI are > > + * edge-interrupts while MSI NSR are level-interrupts. Update the type > > + * accordingly for the parent irqchip. > > + */ > > + if (msi_data->subset_data->icu_group == ICU_GRP_SEI) > > + *type = IRQ_TYPE_EDGE_RISING; > > That's interesting. How is the resampling done here? I'm not sure to understand the question. What does 'resampling' means in such context? MSI SEIs are of type "edge" and use the traditional MSI signalling infrastructure. I'm asking to be sure not to ignore something wrong in my code. > > > > > return 0; > > } Thanks, Miqu?l From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v4 09/14] irqchip/irq-mvebu-icu: add support for System Error Interrupts (SEI) Date: Tue, 21 Aug 2018 11:08:25 +0200 Message-ID: <20180821110825.2fbec982@xps13> References: <20180705124011.7661-1-miquel.raynal@bootlin.com> <20180705124011.7661-10-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marc Zyngier Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , Haim Boot , Will Deacon , Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , Thomas Gleixner , Hanna Hawa , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgTWFyYywKCkknbSBmaW5lIHdpdGggdGhlIHJlc3Qgb2YgdGhlIGNvbW1lbnRzLCBwbGVhc2Ug ZmluZCBqdXN0IG9uZSBsYXN0CnF1ZXN0aW9uIGJlbG93LgoKWy4uLl0KCj4gPiBAQCAtMTMzLDEy ICsxNjQsMzYgQEAgbXZlYnVfaWN1X2lycV9kb21haW5fdHJhbnNsYXRlKHN0cnVjdCBpcnFfZG9t YWluICpkLCBzdHJ1Y3QgaXJxX2Z3c3BlYyAqZndzcGVjLAo+ID4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gPiAgCX0KPiA+ICAKPiA+IC0JLyogTWFzayB0aGUgdHlwZSB0byBwcmV2ZW50IHdyb25nIERU IGNvbmZpZ3VyYXRpb24gKi8KPiA+IC0JKnR5cGUgPSBmd3NwZWMtPnBhcmFtWzJdICYgSVJRX1RZ UEVfU0VOU0VfTUFTSzsKPiA+ICsJLyoKPiA+ICsJICogVGhlIElDVSByZWNlaXZlcyBsZXZlbC1p bnRlcnJ1cHRzLiBNU0kgU0VJIGFyZQo+ID4gKwkgKiBlZGdlLWludGVycnVwdHMgd2hpbGUgTVNJ IE5TUiBhcmUgbGV2ZWwtaW50ZXJydXB0cy4gVXBkYXRlIHRoZSB0eXBlCj4gPiArCSAqIGFjY29y ZGluZ2x5IGZvciB0aGUgcGFyZW50IGlycWNoaXAuCj4gPiArCSAqLwo+ID4gKwlpZiAobXNpX2Rh dGEtPnN1YnNldF9kYXRhLT5pY3VfZ3JvdXAgPT0gSUNVX0dSUF9TRUkpCj4gPiArCQkqdHlwZSA9 IElSUV9UWVBFX0VER0VfUklTSU5HOyAgCj4gCj4gVGhhdCdzIGludGVyZXN0aW5nLiBIb3cgaXMg dGhlIHJlc2FtcGxpbmcgZG9uZSBoZXJlPwoKSSdtIG5vdCBzdXJlIHRvIHVuZGVyc3RhbmQgdGhl IHF1ZXN0aW9uLiBXaGF0IGRvZXMgJ3Jlc2FtcGxpbmcnIG1lYW5zCmluIHN1Y2ggY29udGV4dD8g TVNJIFNFSXMgYXJlIG9mIHR5cGUgImVkZ2UiIGFuZCB1c2UgdGhlIHRyYWRpdGlvbmFsCk1TSSBz aWduYWxsaW5nIGluZnJhc3RydWN0dXJlLiBJJ20gYXNraW5nIHRvIGJlIHN1cmUgbm90IHRvIGln bm9yZQpzb21ldGhpbmcgd3JvbmcgaW4gbXkgY29kZS4KCj4gCj4gPiAgCj4gPiAgCXJldHVybiAw Owo+ID4gIH0KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=