All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pv: fix build failures when building under a path containing 'yes'
Date: Tue, 21 Aug 2018 11:20:23 +0200	[thread overview]
Message-ID: <20180821112023.7237c5c1@windsurf> (raw)
In-Reply-To: <20180820142216.5904-1-peter@korsgaard.com>

Hello,

On Mon, 20 Aug 2018 16:22:16 +0200, Peter Korsgaard wrote:
> Depending on the configuration, the cpp output may contain the string 'yes'
> in a comment if built under a path containing 'yes', confusing the _AIX
> test:
> 
> ${CROSS}-cpp conftest.h
> \# 1 "conftest.h"
> \# 1 "<built-in>"
> \# 1 "<command-line>"
> \# 31 "<command-line>"
> \# 1 "/home/peko/source/buildroot/output-yes/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/stdc-predef.h"
> \# 32 "<command-line>" 2
> \# 1 "conftest.txt"
> 
> If misdetected, the configure script adds -lc128 to LIBS, causing the
> AC_CHECKS_FUNCS check for stat64 to fail, which in turn causes compilation
> errors about redefinition of symbols:
> 
> In file included from ./src/include/pv-internal.h:9:0,
>                  from src/pv/file.c:5:
> ./src/include/config.h:76:18: error: redefinition of 'struct stat'
>   #  define stat64 stat
>                    ^
> Fix it by only matching on 'yes' on a line by itself.
> 
> As pv doesn't cleanly autoreconf (it doesn't use automake and configure.in
> is located in subdir), instead directly patch configure.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  .../pv/0001-configure.in-tighten-AIX-test.patch    | 57 ++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 package/pv/0001-configure.in-tighten-AIX-test.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-08-21  9:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 14:22 [Buildroot] [PATCH] pv: fix build failures when building under a path containing 'yes' Peter Korsgaard
2018-08-20 15:05 ` Yann E. MORIN
2018-08-21  9:20 ` Thomas Petazzoni [this message]
2018-08-29 21:23 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821112023.7237c5c1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.