From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] Scripting language for igt
Date: Tue, 21 Aug 2018 12:14:09 -0700 [thread overview]
Message-ID: <20180821191409.GB4050@intel.com> (raw)
In-Reply-To: <153485180150.9776.9143266230809196927@jlahtine-desk.ger.corp.intel.com>
On Tue, Aug 21, 2018 at 02:43:21PM +0300, Joonas Lahtinen wrote:
> Quoting Chris Wilson (2018-08-20 13:11:15)
>
> <SNIP>
>
> > In both cases it was easy to extend the test beyond the original. Joonas
> > who is more familiar with the later declarative ECMAScript, says he can
> > reduce the boilerplate code even further. (Some of the verbosity is on
> > purpose, since these tests are negative tests and so want to need to dig
> > beneath the usual layers of convenience api, but still the plan should
> > be to autogenerate as much of the ioctl breaking as possible.)
> >
> > TLDR; I want to rewrite BAT and use a script interpreter for speed of
> > execution, ease of test writing, and for automating test generation.
> > I would like to drop duktape into igt/shell, but the initial code drop
> > may be too big to post/review... So I would like to present it as fait
> > accompli and then work on the smaller patches to make the magic happen.
>
> We exchanged some further ideas about this, and my suggestions:
>
> Use v8, for the sake of having a large user base (and the modern
> language features) and JIT for speed.
On the engine side I have no idea what is the best one and honestly
I liked the duktape that Chris found. Seems easy and straighforward...
>
> The igt shell code only really needs to expose IOCTLs and then maybe
> some debugfs derived values. This helps in having a very clearly defined
> interface for the tests to the system (you simply can't poke unintended
> holes through the meant interface, as you are writing all the testing
> code inside the interpreter). On top of which we can add abstractions on
> the ECMAScript files themselves for things like spin batches etc.
Well, I agree that we need a clear separation of what is standard uapi
from what are helpers and abstraction on top of that, but I don't believe
that we necessarily need to do this on top of the engine itself.
Well, I'm not sure how exactly to do this differentiation, maybe function
names standards?
Anyway I'd like to state that specially on display I'd like to see many helpers.
The end goal on display side should be simple calls that give planes
with certain colors on certain position/rotation already committed on
screen, without developer/validator needing to create a framebuffer,
promote to a plane, do a commit, etc.
Thanks a lot for starting this prospection Chris!
Thanks,
Rodrigo.
>
> Regards, Joonas
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-08-21 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 10:11 [igt-dev] Scripting language for igt Chris Wilson
2018-08-21 11:43 ` Joonas Lahtinen
2018-08-21 19:14 ` Rodrigo Vivi [this message]
2018-08-22 12:17 ` Joonas Lahtinen
2018-08-23 20:09 ` Paulo Zanoni
2018-08-23 20:55 ` Rodrigo Vivi
2018-08-23 22:21 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821191409.GB4050@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.