From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by arago-project.org (Postfix) with ESMTPS id A6E5B52AFF for ; Tue, 21 Aug 2018 19:49:43 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id w7LJnaex058467 for ; Tue, 21 Aug 2018 14:49:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1534880976; bh=hxp+K3HkVEwk5KQ+ZoP/LR8OYIdrIrUIBkii/0IYGVM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ehDz3Pm0Yy0kjCz4DQ6WQzL9ioCNbpkxkwvsJkUBVkzw6gpNhAsZceggmvzPnpcKS C1qdfLFG9KCDjgxL4whHzt2tgJem5WLihBKVUocVQXzVbNnyLFUZnQses0CqpFBAn8 aYcgbHLSUkDRDlfrcBfFclJ9LH9oDjpo2DZp76FY= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w7LJnaZ1021396 for ; Tue, 21 Aug 2018 14:49:36 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 21 Aug 2018 14:49:35 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Tue, 21 Aug 2018 14:49:35 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w7LJnZke025090; Tue, 21 Aug 2018 14:49:35 -0500 Date: Tue, 21 Aug 2018 15:48:38 -0400 From: Denys Dmytriyenko To: Eric Ruei Message-ID: <20180821194838.GQ29422@beryl> References: <1534879768-59124-1-git-send-email-e-ruei1@ti.com> <1534879768-59124-2-git-send-email-e-ruei1@ti.com> MIME-Version: 1.0 In-Reply-To: <1534879768-59124-2-git-send-email-e-ruei1@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [PATCH 1/4] gtk+3: update wayland dependency and add patches X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 19:49:44 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Tue, Aug 21, 2018 at 03:29:25PM -0400, Eric Ruei wrote: > - replace wayland dependency mesa with virtual/egl In the past we were using libgbm instead of virtual/egl http://arago-project.org/git/?p=meta-arago.git;a=blob;f=meta-arago-distro/recipes-graphics/wayland/weston_4.0.0.bbappend;hb=HEAD http://arago-project.org/git/?p=meta-arago.git;a=blob;f=meta-arago-distro/recipes-gnome/gtk%2B/gtk%2B3_%25.bbappend;hb=HEAD > - patch to fix egl API calls for GLES2 > > Signed-off-by: Eric Ruei > --- > ...t-wayland.c-cleanup-the-parameters-of-egl.patch | 61 ++++++++++++++++++++++ > .../recipes-gnome/gtk+/gtk+3_%.bbappend | 10 ++++ > 2 files changed, 71 insertions(+) > create mode 100644 meta-arago-distro/recipes-gnome/gtk+/gtk+3/0001-gdkglcontext-wayland.c-cleanup-the-parameters-of-egl.patch > create mode 100644 meta-arago-distro/recipes-gnome/gtk+/gtk+3_%.bbappend > > diff --git a/meta-arago-distro/recipes-gnome/gtk+/gtk+3/0001-gdkglcontext-wayland.c-cleanup-the-parameters-of-egl.patch b/meta-arago-distro/recipes-gnome/gtk+/gtk+3/0001-gdkglcontext-wayland.c-cleanup-the-parameters-of-egl.patch > new file mode 100644 > index 0000000..174dbdd > --- /dev/null > +++ b/meta-arago-distro/recipes-gnome/gtk+/gtk+3/0001-gdkglcontext-wayland.c-cleanup-the-parameters-of-egl.patch > @@ -0,0 +1,61 @@ > +From d4c8511b845de02271b6dcf57a6edbf01f3f1905 Mon Sep 17 00:00:00 2001 > +From: Eric Ruei > +Date: Tue, 21 Aug 2018 11:07:13 -0400 > +Subject: [PATCH] gdkglcontext-wayland.c: cleanup the parameters of egl API > + calls when GLES is used > + > +eglBindAPI: use EGL_OPENGL_ES_API instead of EGL_OPENGL_API > +eglChooseConfig: need to specify EGL_OPENGL_ES2_BIT as EGL_RENDERABLE_TYPE > + > +Upstream-Status: Pending > + > +Signed-off-by: Eric Ruei > +--- > + gdk/wayland/gdkglcontext-wayland.c | 10 +++++++++- > + 1 file changed, 9 insertions(+), 1 deletion(-) > + > +diff --git a/gdk/wayland/gdkglcontext-wayland.c b/gdk/wayland/gdkglcontext-wayland.c > +index 254900d..3361eb3 100644 > +--- a/gdk/wayland/gdkglcontext-wayland.c > ++++ b/gdk/wayland/gdkglcontext-wayland.c > +@@ -314,6 +314,7 @@ gdk_wayland_display_init_gl (GdkDisplay *display) > + GdkWaylandDisplay *display_wayland = GDK_WAYLAND_DISPLAY (display); > + EGLint major, minor; > + EGLDisplay dpy; > ++ gboolean use_es = (_gdk_gl_flags & GDK_GL_GLES) != 0 ; > + > + if (display_wayland->have_egl) > + return TRUE; > +@@ -326,7 +327,7 @@ gdk_wayland_display_init_gl (GdkDisplay *display) > + if (!eglInitialize (dpy, &major, &minor)) > + return FALSE; > + > +- if (!eglBindAPI (EGL_OPENGL_API)) > ++ if (!eglBindAPI (use_es?EGL_OPENGL_ES_API:EGL_OPENGL_API)) > + return FALSE; > + > + display_wayland->egl_display = dpy; > +@@ -379,6 +380,7 @@ find_eglconfig_for_window (GdkWindow *window, > + EGLint count; > + EGLConfig *configs, chosen_config; > + gboolean use_rgba; > ++ gboolean use_es = (_gdk_gl_flags & GDK_GL_GLES) != 0 ; > + > + int i = 0; > + > +@@ -395,6 +397,12 @@ find_eglconfig_for_window (GdkWindow *window, > + attrs[i++] = EGL_BLUE_SIZE; > + attrs[i++] = 1; > + > ++ if (use_es) > ++ { > ++ attrs[i++] = EGL_RENDERABLE_TYPE; > ++ attrs[i++] = EGL_OPENGL_ES2_BIT; > ++ } > ++ > + use_rgba = (visual == gdk_screen_get_rgba_visual (gdk_display_get_default_screen (display))); > + > + if (use_rgba) > +-- > +1.9.1 > + > diff --git a/meta-arago-distro/recipes-gnome/gtk+/gtk+3_%.bbappend b/meta-arago-distro/recipes-gnome/gtk+/gtk+3_%.bbappend > new file mode 100644 > index 0000000..d3fe505 > --- /dev/null > +++ b/meta-arago-distro/recipes-gnome/gtk+/gtk+3_%.bbappend > @@ -0,0 +1,10 @@ > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > + > +PACKAGECONFIG[wayland] = "--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols libxkbcommon virtual/egl wayland-native" > +GTKGLIBC_RRECOMMENDS = "${GTKBASE_RRECOMMENDS}" > + > +PR_append = ".arago0" > + > +SRC_URI += "\ > + file://0001-gdkglcontext-wayland.c-cleanup-the-parameters-of-egl.patch \ > +" > -- > 1.9.1 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago