From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 2/4] e2fsprogs: build shared library for the host
Date: Wed, 22 Aug 2018 00:11:41 +0200 [thread overview]
Message-ID: <20180821221141.GU15347@scaer> (raw)
In-Reply-To: <20180821215954.11971-3-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-08-21 23:59 +0200, Thomas Petazzoni spake thusly:
> By default, the e2fsprogs package builds and installs only static
> libraries, unless --enable-elf-shlibs is passed. For the target
> variant, we pass the appropriate
> --enable-elf-shlibs/--disable-elf-shlibs options, but not for the host
> package, and therefore static e2fsprogs libraries get installed.
>
> However, on the host, our policy is to build shared libraries and not
> static libraries, as visible in the default configure options passed
> to host package in pkg-autotools.mk (--enable-shared
> --disable-static). Let's do the same with e2fsprogs.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/e2fsprogs/e2fsprogs.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
> index efc10d0e99..65f9774afb 100644
> --- a/package/e2fsprogs/e2fsprogs.mk
> +++ b/package/e2fsprogs/e2fsprogs.mk
> @@ -27,7 +27,8 @@ HOST_E2FSPROGS_CONF_OPTS = \
> --disable-libblkid \
> --disable-libuuid \
> --enable-symlink-install \
> - --disable-testio-debug
> + --disable-testio-debug \
> + --enable-elf-shlibs
I lknow this is not your fault, but I find it more readable when the
--disable are all grouped together, and the --enable ones as well.
It also helps spot potentialy issues when the ordering is the same btw
host and target variants.
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> # Set the binary directories to "/bin" and "/sbin", as busybox does,
> # so that we do not end up with two versions of e2fs tools.
> --
> 2.14.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-08-21 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 21:59 [Buildroot] [PATCH next 0/4] btrfs-progs related improvements Thomas Petazzoni
2018-08-21 21:59 ` [Buildroot] [PATCH next 1/4] lzo: build shared library for the host Thomas Petazzoni
2018-08-21 22:07 ` Yann E. MORIN
2018-08-21 21:59 ` [Buildroot] [PATCH next 2/4] e2fsprogs: " Thomas Petazzoni
2018-08-21 22:11 ` Yann E. MORIN [this message]
2018-08-22 11:46 ` Thomas Petazzoni
2018-08-21 21:59 ` [Buildroot] [PATCH next 3/4] btrfs-progs: drop dependency on e2fsprogs by not building btrfs-convert Thomas Petazzoni
2018-08-21 22:15 ` Yann E. MORIN
2018-08-21 21:59 ` [Buildroot] [PATCH next 4/4] btrfs-progs: make e2fsprogs an optional dependency Thomas Petazzoni
2018-08-21 22:18 ` Yann E. MORIN
2018-08-21 22:08 ` [Buildroot] [PATCH next 0/4] btrfs-progs related improvements Yann E. MORIN
2018-08-22 11:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821221141.GU15347@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.