All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	Ingo Molnar <mingo@kernel.org>, Leo Yan <leo.yan@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] sched: idle: Avoid retaining the tick when it has been stopped
Date: Tue, 21 Aug 2018 16:21:44 -0700	[thread overview]
Message-ID: <20180821232144.GW94926@atomide.com> (raw)
In-Reply-To: <2161372.IsD4PDzmmY@aspire.rjw.lan>

* Rafael J. Wysocki <rjw@rjwysocki.net> [691231 23:00]:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> If the tick has been stopped already, but the governor has not asked to
> stop it (which it can do sometimes), the idle loop should invoke
> tick_nohz_idle_stop_tick(), to let tick_nohz_stop_tick() take care
> of this case properly.
> 
> Fixes: 554c8aa8ecad (sched: idle: Select idle state before stopping the tick)

This patch seems to fix an issue where boot hangs occasionally
on beagleboard-xm with ARM multi_v7_defconfig as reported by
kernelci.org and Mark Brown earlier at [0].

At least so far no boot hangs for me with this fix, so:

Tested-by: Tony Lindgren <tony@atomide.com>

[0] https://www.spinics.net/lists/linux-mmc/msg50480.html

      parent reply	other threads:[~2018-08-21 23:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 17:08 [PATCH] sched: idle: Avoid retaining the tick when it has been stopped Rafael J. Wysocki
2018-08-10  6:19 ` leo.yan
2018-08-10  7:15   ` Rafael J. Wysocki
2018-08-16 13:27 ` Frederic Weisbecker
2018-08-17  9:32   ` Rafael J. Wysocki
2018-08-17 10:05     ` Rafael J. Wysocki
2018-08-17 14:12     ` Frederic Weisbecker
2018-08-18 21:57       ` Rafael J. Wysocki
2018-08-19  0:36         ` leo.yan
2018-08-19  7:57           ` Rafael J. Wysocki
2018-08-20  9:14         ` Peter Zijlstra
2018-08-20 14:42         ` Frederic Weisbecker
2018-08-20 21:21           ` Rafael J. Wysocki
2018-08-21 23:21 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821232144.GW94926@atomide.com \
    --to=tony@atomide.com \
    --cc=broonie@kernel.org \
    --cc=frederic@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.