From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsPpg-0007A1-Rk for qemu-devel@nongnu.org; Wed, 22 Aug 2018 05:53:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsPpd-0004FQ-5C for qemu-devel@nongnu.org; Wed, 22 Aug 2018 05:53:44 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53822 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsPpc-0004F1-TQ for qemu-devel@nongnu.org; Wed, 22 Aug 2018 05:53:41 -0400 Date: Wed, 22 Aug 2018 10:53:30 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180822095330.GA29063@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180808104930.23133-1-berrange@redhat.com> <20180808104930.23133-4-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] ui: remove support for SDL1.2 in favour of SDL2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Libvirt , Gerd Hoffmann , Fam Zheng On Wed, Aug 08, 2018 at 02:51:01PM +0100, Peter Maydell wrote: > On 8 August 2018 at 11:49, Daniel P. Berrang=C3=A9 wrote: > > SDL1.2 was deprecated in the 2.12.0 release with: > > > > commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa > > Author: Daniel P. Berrange > > Date: Mon Jan 15 14:25:33 2018 +0000 > > > > ui: deprecate use of SDL 1.2 in favour of 2.0 series > > > > The SDL 2.0 release was made in Aug, 2013: > > > > https://www.libsdl.org/release/ > > > > That will soon be 4 + 1/2 years ago, which is enough time to cons= ider > > the 2.0 series widely supported. > > > > Thus we deprecate the SDL 1.2 support, which will allow us to del= ete it > > in the last release of 2018. By this time, SDL 2.0 will be more t= han 5 > > years old. > > > > Signed-off-by: Daniel P. Berrange > > Reviewed-by: Marc-Andr=C3=A9 Lureau > > Message-id: 20180115142533.24585-1-berrange@redhat.com > > Signed-off-by: Gerd Hoffmann > > > > It is thus able to be removed in the 3.1.0 release. >=20 > At least one of the BSD VMs in tests/vm/ is still using SDL1.2. > I think we should update that VM before we drop SDL1.2 support. I confirmed that the freebsd & netbsd images still work as SDL just gets automatically disabled by configure. The openbsd image breaks hard though because SDL is the only available audio backend on openbsd, effectively making SDL a mandatory requirement. So we definitely need to update the openbsd image to have SDL2. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|