From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ganesh Goudar Subject: Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts Date: Wed, 22 Aug 2018 15:59:04 +0530 Message-ID: <20180822102858.GA8912@chelsio.com> References: <20180805172238.GH15082@ZenIV.linux.org.uk> <20180806121459.GA5591@chelsio.com> <20180814212524.GT6515@ZenIV.linux.org.uk> <20180817130536.GA31768@chelsio.com> <20180817154320.GD6515@ZenIV.linux.org.uk> <20180817180949.GE6515@ZenIV.linux.org.uk> <20180817185841.GF6515@ZenIV.linux.org.uk> <20180817185944.GG6515@ZenIV.linux.org.uk> <20180817194410.GH6515@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Rahul Lakkireddy , David Miller , "netdev@vger.kernel.org" To: Al Viro Return-path: Received: from stargate.chelsio.com ([12.32.117.8]:40842 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726849AbeHVNx0 (ORCPT ); Wed, 22 Aug 2018 09:53:26 -0400 Content-Disposition: inline In-Reply-To: <20180817194410.GH6515@ZenIV.linux.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: Hi Al, All the issues you have mentioned make sense to me, I will fix them and try to have them tested on big endian machine. I got all the patches from net-endian.chelsio they all look good, But I am yet to go through (struct cxgb4_next_header .match_val/.match_mask/mask should be net-endian). regarding "le64_to_cpu(*src)", I think we have not tested our vf driver on a big endian machine. will address this as well. Thanks Ganesh