From: Eryu Guan <guaneryu@gmail.com>
To: Su Yue <suy.fnst@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
Date: Wed, 22 Aug 2018 19:45:24 +0800 [thread overview]
Message-ID: <20180822114524.GI2791@desktop> (raw)
In-Reply-To: <20180822083201.14851-1-suy.fnst@cn.fujitsu.com>
On Wed, Aug 22, 2018 at 04:32:01PM +0800, Su Yue wrote:
> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
> set and report empty attribute values) changed output format of
> empty attribute value with quotes.
>
> Here, change generic/062.out to match the actual output.
>
> [1]: https://git.savannah.nongnu.org/git/attr.git
>
> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
> ---
> tests/generic/062.out | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/tests/generic/062.out b/tests/generic/062.out
> index 8cc3c655..9b9cd744 100644
> --- a/tests/generic/062.out
> +++ b/tests/generic/062.out
> @@ -13,7 +13,7 @@ SCRATCH_MNT/reg
>
> *** set/get one initially empty attribute
> # file: SCRATCH_MNT/reg
> -user.name
> +user.name=""
This breaks tests with old attr version, we should filter the output so
that both old and new attr could pass the test.
Please see the discussions in this thread.
https://patchwork.kernel.org/patch/10521875/
Thanks,
Eryu
next prev parent reply other threads:[~2018-08-22 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 8:32 [PATCH] xfstests: generic/062: Change output of empty attribute values Su Yue
2018-08-22 11:45 ` Eryu Guan [this message]
2018-08-23 1:09 ` Su Yue
2018-08-22 11:49 ` Filipe Manana
2018-08-23 0:29 ` Su Yue
2018-08-22 13:50 ` Theodore Y. Ts'o
2018-08-23 0:48 ` Su Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822114524.GI2791@desktop \
--to=guaneryu@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=suy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.