From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] Remove extra goto label from nvmet_ns_enable
Date: Wed, 22 Aug 2018 06:00:57 -0700 [thread overview]
Message-ID: <20180822130057.GA508@infradead.org> (raw)
In-Reply-To: <20180809133344.GA11707@machine1>
On Thu, Aug 09, 2018@07:03:44PM +0530, Milan P. Gandhi wrote:
> Currently nvmet_ns_enable has two labels viz. out_unlock and
> out_dev_put, and the reverse call from out_dev_put to out_unlock
> is little bit confusing. We could simplify it by calling
> nvmet_ns_dev_disable before. This would eliminate need for
> 2nd label out_dev_put.
>
> Also, this function already initializes ret variable to 0,
> so there is no need to initialize it to 0 before out_unlock,
> so removing it.
>
> Signed-off-by: Milan P. Gandhi <mgandhi at redhat.com>
The code before this patch actually is simpler and cleaner..
prev parent reply other threads:[~2018-08-22 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 13:33 [PATCH] Remove extra goto label from nvmet_ns_enable Milan P. Gandhi
[not found] ` <CAMNNMLFyLwk1n2_WTzqEhTJ=U+qseoFKe0=BV94aDZDekVrmuA@mail.gmail.com>
2018-08-09 14:03 ` Milan P. Gandhi
2018-08-22 13:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822130057.GA508@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.