All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Biehl Pasquali <pasqualirb@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ALSA: pcm: Return 0 when size < start_threshold in capture
Date: Wed, 22 Aug 2018 12:25:24 -0300	[thread overview]
Message-ID: <20180822152524.GA13037@localhost.localdomain> (raw)
In-Reply-To: <s5hy3cye8wu.wl-tiwai@suse.de>

Takashi wrote:
> Almost good, but still not perfect, unfortunately :)
> The patch should be applicable onto the kernel tree as is with -p1
> option, i.e. the diff should be like
>   --- a/sound/core/pcm_lib.c
>   +++ b/sound/core/pcm_lib.c
>
> But never mind, I'll apply this manually at this time, just keep the
> above in mind for the next time.

Ok, thank you!

The .orig thing is ok if I had used the full pathname?

diff does not generate a/ and b/ (at least with '-up'
options). By the way, 'diff -up' is what
submitting-patches document recommends when no git tree
is available.

  reply	other threads:[~2018-08-22 15:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 15:03 [PATCH v2] ALSA: pcm: Return 0 when size < start_threshold in capture Ricardo Biehl Pasquali
2018-08-22 15:08 ` Takashi Iwai
2018-08-22 15:25   ` Ricardo Biehl Pasquali [this message]
2018-08-22 15:46     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822152524.GA13037@localhost.localdomain \
    --to=pasqualirb@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.