All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 2/3] phylib: add support for reset-gpios
Date: Wed, 22 Aug 2018 20:26:15 +0200	[thread overview]
Message-ID: <20180822182615.GA21464@ravnborg.org> (raw)
In-Reply-To: <73450612-5333-d00e-9889-be0633938797@pengutronix.de>

Hi Ahmad.

On Wed, Aug 22, 2018 at 03:14:57PM +0200, Ahmad Fatoum wrote:
> Hello Sam,
> 
> On 08/21/2018 09:46 PM, Sam Ravnborg wrote:
> > But macb.txt or the general bindigns do not mention
> > a mdio child.
> > And the Linux macb_main.c do not support a "mdio" node either.
> > So my best guess is that the "mdio" support in macb was accidently
> > ported over from fec-imx when adding DT support.
> [snip]
> > Considering the above I will do the following:
> > a) Remove "mdio" support from macb.c
> 
> While submitting a macb patch to linux-netdev, I was asked [1] to add
> support for a "mdio" subtree in the macb binding. I intend to submit
> it when net-next opens for inclusion into Linux v4.20.
> That way, macb would look at phys in the list of its children as well
> as the children of its "mdio" child.
> 
> Just a heads up to avoid removing functionality that would've to be
> reinstated later on...
> 
> [1]: https://www.spinics.net/lists/netdev/msg519196.html

Thanks for bringing this to my attention.
I will leave the code as-is.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-08-22 18:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 14:52 [PATCH v3 0/3] Add Davicom phy + reset-gpios Sam Ravnborg
2018-08-20 14:56 ` [PATCH v3 1/3] phylib: add Davicom PHY support Sam Ravnborg
2018-08-20 14:56 ` [PATCH v3 2/3] phylib: add support for reset-gpios Sam Ravnborg
2018-08-21  7:50   ` Sascha Hauer
2018-08-21 19:46     ` Sam Ravnborg
2018-08-22 13:14       ` Ahmad Fatoum
2018-08-22 18:26         ` Sam Ravnborg [this message]
2018-08-20 14:56 ` [PATCH v3 3/3] at91sam9263ek: add PHY, miitool etc. to config Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822182615.GA21464@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.