Re: [Qemu-devel] [PATCH] tests/migration: Enable the migration test on s390x, too

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 23 Aug 2018 14:25:20 +0200
Thomas Huth <thuth@redhat.com> wrote:

> We can re-use the s390-ccw bios code to implement a small firmware
> for a s390x guest which prints out the "A" and "B" characters and
> modifies the memory, as required for the migration test.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/Makefile.include               |   1 +
>  tests/migration-test.c               |  23 ++
>  tests/migration/s390x-a-b-rebuild.sh |  42 ++++
>  tests/migration/s390x-a-b.c          |  35 +++
>  tests/migration/s390x-a-b.h          | 427 +++++++++++++++++++++++++++++++++++
>  5 files changed, 528 insertions(+)
>  create mode 100755 tests/migration/s390x-a-b-rebuild.sh
>  create mode 100644 tests/migration/s390x-a-b.c
>  create mode 100644 tests/migration/s390x-a-b.h

Hm, I wanted to comment that those new files should be added to the
MAINTAINERS file pattern (here as well :), but tests/migration does not
seem to have an entry in MAINTAINERS yet...


> diff --git a/tests/migration/s390x-a-b.h b/tests/migration/s390x-a-b.h
> new file mode 100644
> index 0000000..eb1bab4
> --- /dev/null
> +++ b/tests/migration/s390x-a-b.h
> @@ -0,0 +1,427 @@
> +/*
> + * This file is automatically generated from tests/migration/s390x-a-b.c, edit
> + * that and then run tests/migration/s390x-a-b-rebuild.sh to update, and then
> + * remember to send both in your patch submission.
> + */

And here I assumed that this file would be lovingly hand-crafted :)

Looks sane to me:

Acked-by: Cornelia Huck <cohuck@redhat.com>

Juan, from your previous mails I gather that you'll take this through
your tree, right?