From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47512)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1fstM6-0005vQ-Sa
	for qemu-devel@nongnu.org; Thu, 23 Aug 2018 13:25:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1fstM3-00072d-A8
	for qemu-devel@nongnu.org; Thu, 23 Aug 2018 13:25:10 -0400
Date: Thu, 23 Aug 2018 14:25:01 -0300
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20180823172501.GM3778@localhost.localdomain>
References: <1534931204-112747-1-git-send-email-imammedo@redhat.com>
	<c88ef55d-738b-57bc-f00f-b4a4d7303bd6@redhat.com>
	<20180822150536.6d79a1e1@redhat.com>
	<20180822180112.GB3778@localhost.localdomain>
	<20180823101406.06320b35@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180823101406.06320b35@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for
 hotpluggable area
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: haozhong.zhang@intel.com, xiaoguangrong.eric@gmail.com, mst@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, john.ji@intel.com, Laszlo Ersek <lersek@redhat.com>

On Thu, Aug 23, 2018 at 10:14:06AM +0200, Igor Mammedov wrote:
> On Wed, 22 Aug 2018 15:01:12 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
[...]
> > However, have you considered keeping adding separate entries for
> > NVDIMM devices only (so we follow the spec), but add a single
> > (numa_nodes-1, MEM_AFFINITY_HOTPLUGGABLE|MEM_AFFINITY_ENABLED)
> > entry to the rest?
> Indeed, I did. It doesn't work either.

When exactly it didn't work?  Did nvdimm + memory hotplug ever
worked together on Windows guests?

For all the other cases there should be absolutely no difference:

nvdimm users would still get a spec-compliant SRAT table (like on
QEMU 3.0).

Memory hotplug users w/o nvdimm would get the same ACPI table
that they would get after applying this patch (i.e. the one we
had before commit 848a1cc1e ("hw/acpi-build: build SRAT memory
affinity structures for DIMM devices").

-- 
Eduardo