From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/ Date: Fri, 24 Aug 2018 17:43:29 +0200 Message-ID: <20180824154329.GA26678@ravnborg.org> References: <20180812184152.GA22343@ravnborg.org> <20180812184629.3808-1-sam@ravnborg.org> <20180824102843.666bc465@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180824102843.666bc465@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Mark Rutland , devicetree@vger.kernel.org, Alexandre Belloni , linux-pwm@vger.kernel.org, Nicolas Ferre , dri-devel@lists.freedesktop.org, Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org List-Id: linux-pwm@vger.kernel.org SGkgQm9yaXMuCgpPbiBGcmksIEF1ZyAyNCwgMjAxOCBhdCAxMDoyODo0M0FNICswMjAwLCBCb3Jp cyBCcmV6aWxsb24gd3JvdGU6Cj4gT24gU3VuLCAxMiBBdWcgMjAxOCAyMDo0NjoyMyArMDIwMAo+ IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz4gd3JvdGU6Cj4gCj4gPiBVc2UgdmVuZG9y IG5hbWUgZm9yIGRpcmVjdG9yeSwgYWRkaW5nIGEgc3VpdGFibGUgcGxhY2UKPiA+IGZvciBtb3Jl IGF0bWVsIERSTSBkcml2ZXJzLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBTYW0gUmF2bmJvcmcg PHNhbUByYXZuYm9yZy5vcmc+Cj4gPiBDYzogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxs b25AYm9vdGxpbi5jb20+Cj4gPiAtLS0KPiA+ICBNQUlOVEFJTkVSUyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDIgKy0KPiA+ICBkcml2ZXJzL2dwdS9k cm0vS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDIgKy0KPiA+ ICBkcml2ZXJzL2dwdS9kcm0vTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8IDIgKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0ve2F0bWVsLWhsY2RjID0+IGF0bWVsfS9L Y29uZmlnICAgICAgICAgICAgICB8IDYgKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL3thdG1l bC1obGNkYyA9PiBhdG1lbH0vTWFrZWZpbGUgICAgICAgICAgICAgfCAwCj4gPiAgZHJpdmVycy9n cHUvZHJtL3thdG1lbC1obGNkYyA9PiBhdG1lbH0vYXRtZWxfaGxjZGNfY3J0Yy5jICAgfCAwCj4g PiAgZHJpdmVycy9ncHUvZHJtL3thdG1lbC1obGNkYyA9PiBhdG1lbH0vYXRtZWxfaGxjZGNfZGMu YyAgICAgfCAwCj4gPiAgZHJpdmVycy9ncHUvZHJtL3thdG1lbC1obGNkYyA9PiBhdG1lbH0vYXRt ZWxfaGxjZGNfZGMuaCAgICAgfCAwCj4gPiAgZHJpdmVycy9ncHUvZHJtL3thdG1lbC1obGNkYyA9 PiBhdG1lbH0vYXRtZWxfaGxjZGNfb3V0cHV0LmMgfCAwCj4gPiAgZHJpdmVycy9ncHUvZHJtL3th dG1lbC1obGNkYyA9PiBhdG1lbH0vYXRtZWxfaGxjZGNfcGxhbmUuYyAgfCAwCj4gPiAgMTAgZmls ZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gIHJlbmFtZSBk cml2ZXJzL2dwdS9kcm0ve2F0bWVsLWhsY2RjID0+IGF0bWVsfS9LY29uZmlnICg4MyUpCj4gPiAg cmVuYW1lIGRyaXZlcnMvZ3B1L2RybS97YXRtZWwtaGxjZGMgPT4gYXRtZWx9L01ha2VmaWxlICgx MDAlKQo+ID4gIHJlbmFtZSBkcml2ZXJzL2dwdS9kcm0ve2F0bWVsLWhsY2RjID0+IGF0bWVsfS9h dG1lbF9obGNkY19jcnRjLmMgKDEwMCUpCj4gPiAgcmVuYW1lIGRyaXZlcnMvZ3B1L2RybS97YXRt ZWwtaGxjZGMgPT4gYXRtZWx9L2F0bWVsX2hsY2RjX2RjLmMgKDEwMCUpCj4gPiAgcmVuYW1lIGRy aXZlcnMvZ3B1L2RybS97YXRtZWwtaGxjZGMgPT4gYXRtZWx9L2F0bWVsX2hsY2RjX2RjLmggKDEw MCUpCj4gPiAgcmVuYW1lIGRyaXZlcnMvZ3B1L2RybS97YXRtZWwtaGxjZGMgPT4gYXRtZWx9L2F0 bWVsX2hsY2RjX291dHB1dC5jICgxMDAlKQo+ID4gIHJlbmFtZSBkcml2ZXJzL2dwdS9kcm0ve2F0 bWVsLWhsY2RjID0+IGF0bWVsfS9hdG1lbF9obGNkY19wbGFuZS5jICgxMDAlKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwo+ID4gaW5kZXggOTZlOThlMjA2 YjBkLi4wOWNlNzZhOWExZGMgMTAwNjQ0Cj4gPiAtLS0gYS9NQUlOVEFJTkVSUwo+ID4gKysrIGIv TUFJTlRBSU5FUlMKPiA+IEBAIC00NjgxLDcgKzQ2ODEsNyBAQCBEUk0gRFJJVkVSUyBGT1IgQVRN RUwgSExDREMKPiA+ICBNOglCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGlu LmNvbT4KPiA+ICBMOglkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiAgUzoJU3Vw cG9ydGVkCj4gPiAtRjoJZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjLwo+ID4gK0Y6CWRyaXZl cnMvZ3B1L2RybS9hdG1lbC9hdG1lbC1obGNkYyoKPiAKPiAJCQkgICAgICBhdG1lbF9obGNkYyoK PiAKPiBBbHNvLCBJIHRoaW5rIHlvdSBjYW4ga2VlcCB0aGUgd2hvbGUgZGlyZWN0b3J5LCBhbmQg YWRkIHlvdXIgbmFtZSBwbHVzCj4gdXBkYXRlIHRoZSBlbnRyeSBkZXNjcmlwdGlvbiBhZnRlciBh ZGRpbmcgY29kZSBmb3IgdGhlIExDREMgYmxvY2suCgpUaGFua3MsIHdpbGwgZG8gc28gaW4gdjIu Cgo+IAo+ID4gIEY6CURvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2F0 bWVsLwo+ID4gIFQ6CWdpdCBnaXQ6Ly9hbm9uZ2l0LmZyZWVkZXNrdG9wLm9yZy9kcm0vZHJtLW1p c2MKPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vS2NvbmZpZyBiL2RyaXZl cnMvZ3B1L2RybS9LY29uZmlnCj4gPiBpbmRleCAyYTcyZDJmZWI3NmQuLjQxMzBkZjBjMGRiYSAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9LY29uZmlnCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vS2NvbmZpZwo+ID4gQEAgLTIzMiw3ICsyMzIsNyBAQCBzb3VyY2UgImRyaXZlcnMv Z3B1L2RybS9jaXJydXMvS2NvbmZpZyIKPiA+ICAKPiA+ICBzb3VyY2UgImRyaXZlcnMvZ3B1L2Ry bS9hcm1hZGEvS2NvbmZpZyIKPiA+ICAKPiA+IC1zb3VyY2UgImRyaXZlcnMvZ3B1L2RybS9hdG1l bC1obGNkYy9LY29uZmlnIgo+ID4gK3NvdXJjZSAiZHJpdmVycy9ncHUvZHJtL2F0bWVsL0tjb25m aWciCj4gPiAgCj4gPiAgc291cmNlICJkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9LY29uZmlnIgo+ ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9NYWtlZmlsZSBiL2RyaXZlcnMv Z3B1L2RybS9NYWtlZmlsZQo+ID4gaW5kZXggZWY5ZjNkYWIyODdmLi5jZTk4Mjk5NjcxMjggMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vTWFrZWZpbGUKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9NYWtlZmlsZQo+ID4gQEAgLTc2LDcgKzc2LDcgQEAgb2JqLSQoQ09ORklHX0RSTV9H TUE1MDApICs9IGdtYTUwMC8KPiA+ICBvYmotJChDT05GSUdfRFJNX1VETCkgKz0gdWRsLwo+ID4g IG9iai0kKENPTkZJR19EUk1fQVNUKSArPSBhc3QvCj4gPiAgb2JqLSQoQ09ORklHX0RSTV9BUk1B REEpICs9IGFybWFkYS8KPiA+IC1vYmotJChDT05GSUdfRFJNX0FUTUVMX0hMQ0RDKQkrPSBhdG1l bC1obGNkYy8KPiA+ICtvYmotJChDT05GSUdfRFJNX0FUTUVMKQkrPSBhdG1lbC8KPiA+ICBvYmot JChDT05GSUdfRFJNX1JDQVJfRFUpICs9IHJjYXItZHUvCj4gPiAgb2JqLSQoQ09ORklHX0RSTV9T SE1PQklMRSkgKz1zaG1vYmlsZS8KPiA+ICBvYmoteQkJCSs9IG9tYXBkcm0vCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL0tjb25maWcgYi9kcml2ZXJzL2dwdS9k cm0vYXRtZWwvS2NvbmZpZwo+ID4gc2ltaWxhcml0eSBpbmRleCA4MyUKPiA+IHJlbmFtZSBmcm9t IGRyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNkYy9LY29uZmlnCj4gPiByZW5hbWUgdG8gZHJpdmVy cy9ncHUvZHJtL2F0bWVsL0tjb25maWcKPiA+IGluZGV4IDMyYmNjNGJhZDA2YS4uN2NkMzg2MmY5 ZDE4IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL0tjb25maWcK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hdG1lbC9LY29uZmlnCj4gPiBAQCAtMSw2ICsxLDEy IEBACj4gPiArY29uZmlnIERSTV9BVE1FTAo+ID4gKwlib29sCj4gPiArCWhlbHAKPiA+ICsJICBF bmFibGUgQXRtZWwgRFJNIHN1cHBvcnQKPiA+ICsKPiAKPiBOb3Qgc3VyZSB3aHkgeW91IG5lZWQg YW4gZXh0cmEgS2NvbmZpZyBvcHRpb24/IEFuZCBpZiB5b3UgcmVhbGx5IGRvCj4gKGJlY2F1c2Ug eW91IHdhbnQgdG8gc2hhcmUgY29tbW9uIGNvZGUpLCBpdCBzaG91bGQgYmUgaW1wbGljaXRseQo+ IHNlbGVjdGVkIGJ5IERSTV9BVE1FTF9ITENEQyBhbmQgRFJNX0FUTUVMX0xDREMuCgpUaGUgZXh0 cmEgY29uZmlnIG9wdGlvbiBpcyB0byBhdm9pZCBleHBvc2luZyBldmVyeSBzaW5nbGUgb3B0aW9u CnRvIHRoZSBkcm0gbWFrZWZpbGUsIGFuZCBpdCBpcyBpbmRlZWQgc2VsZWN0ZWQgYnkgdGhlIGlu ZGl2aWR1YWwKZHJpdmVycy4KU2ltaWxhciBwYXR0ZXJuIHVzZWQgaW4gYXJtL0tjb25maWcuCkJ1 dCBJIHNlZSBtb3N0IG90aGVyIHBsYWNlcyBoYXZlIGEgcHJvbXB0IHRoYXQgZW5hYmxlIHRoZSBk cml2ZXJzCnNvIEkgd2lsbCBjaGFuZ2UgdGhpcyB0byBhIHByb21wdCBpbiB2Mi4KCglTYW0KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: sam@ravnborg.org (Sam Ravnborg) Date: Fri, 24 Aug 2018 17:43:29 +0200 Subject: [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/ In-Reply-To: <20180824102843.666bc465@bbrezillon> References: <20180812184152.GA22343@ravnborg.org> <20180812184629.3808-1-sam@ravnborg.org> <20180824102843.666bc465@bbrezillon> Message-ID: <20180824154329.GA26678@ravnborg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris. On Fri, Aug 24, 2018 at 10:28:43AM +0200, Boris Brezillon wrote: > On Sun, 12 Aug 2018 20:46:23 +0200 > Sam Ravnborg wrote: > > > Use vendor name for directory, adding a suitable place > > for more atmel DRM drivers. > > > > Signed-off-by: Sam Ravnborg > > Cc: Boris Brezillon > > --- > > MAINTAINERS | 2 +- > > drivers/gpu/drm/Kconfig | 2 +- > > drivers/gpu/drm/Makefile | 2 +- > > drivers/gpu/drm/{atmel-hlcdc => atmel}/Kconfig | 6 ++++++ > > drivers/gpu/drm/{atmel-hlcdc => atmel}/Makefile | 0 > > drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_crtc.c | 0 > > drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_dc.c | 0 > > drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_dc.h | 0 > > drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_output.c | 0 > > drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_plane.c | 0 > > 10 files changed, 9 insertions(+), 3 deletions(-) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/Kconfig (83%) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/Makefile (100%) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_crtc.c (100%) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_dc.c (100%) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_dc.h (100%) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_output.c (100%) > > rename drivers/gpu/drm/{atmel-hlcdc => atmel}/atmel_hlcdc_plane.c (100%) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 96e98e206b0d..09ce76a9a1dc 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -4681,7 +4681,7 @@ DRM DRIVERS FOR ATMEL HLCDC > > M: Boris Brezillon > > L: dri-devel at lists.freedesktop.org > > S: Supported > > -F: drivers/gpu/drm/atmel-hlcdc/ > > +F: drivers/gpu/drm/atmel/atmel-hlcdc* > > atmel_hlcdc* > > Also, I think you can keep the whole directory, and add your name plus > update the entry description after adding code for the LCDC block. Thanks, will do so in v2. > > > F: Documentation/devicetree/bindings/display/atmel/ > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index 2a72d2feb76d..4130df0c0dba 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -232,7 +232,7 @@ source "drivers/gpu/drm/cirrus/Kconfig" > > > > source "drivers/gpu/drm/armada/Kconfig" > > > > -source "drivers/gpu/drm/atmel-hlcdc/Kconfig" > > +source "drivers/gpu/drm/atmel/Kconfig" > > > > source "drivers/gpu/drm/rcar-du/Kconfig" > > > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > > index ef9f3dab287f..ce9829967128 100644 > > --- a/drivers/gpu/drm/Makefile > > +++ b/drivers/gpu/drm/Makefile > > @@ -76,7 +76,7 @@ obj-$(CONFIG_DRM_GMA500) += gma500/ > > obj-$(CONFIG_DRM_UDL) += udl/ > > obj-$(CONFIG_DRM_AST) += ast/ > > obj-$(CONFIG_DRM_ARMADA) += armada/ > > -obj-$(CONFIG_DRM_ATMEL_HLCDC) += atmel-hlcdc/ > > +obj-$(CONFIG_DRM_ATMEL) += atmel/ > > obj-$(CONFIG_DRM_RCAR_DU) += rcar-du/ > > obj-$(CONFIG_DRM_SHMOBILE) +=shmobile/ > > obj-y += omapdrm/ > > diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel/Kconfig > > similarity index 83% > > rename from drivers/gpu/drm/atmel-hlcdc/Kconfig > > rename to drivers/gpu/drm/atmel/Kconfig > > index 32bcc4bad06a..7cd3862f9d18 100644 > > --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig > > +++ b/drivers/gpu/drm/atmel/Kconfig > > @@ -1,6 +1,12 @@ > > +config DRM_ATMEL > > + bool > > + help > > + Enable Atmel DRM support > > + > > Not sure why you need an extra Kconfig option? And if you really do > (because you want to share common code), it should be implicitly > selected by DRM_ATMEL_HLCDC and DRM_ATMEL_LCDC. The extra config option is to avoid exposing every single option to the drm makefile, and it is indeed selected by the individual drivers. Similar pattern used in arm/Kconfig. But I see most other places have a prompt that enable the drivers so I will change this to a prompt in v2. Sam