All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Mikko.Rapeli@bmw.de>
To: <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cmake: add CMAKE_SYSROOT to generated toolchain file
Date: Fri, 24 Aug 2018 16:17:28 +0000	[thread overview]
Message-ID: <20180824161727.GL20864@hiutale> (raw)
In-Reply-To: <CAMKF1sqc6fQhZfSKZ80D2dyHL_D=2hRAS1zMFKScP8MpXgQRbA@mail.gmail.com>

On Fri, Aug 24, 2018 at 08:51:42AM -0700, Khem Raj wrote:
> On Fri, Aug 24, 2018 at 8:48 AM <Mikko.Rapeli@bmw.de> wrote:
> > So to me it looks like using SYSTEM with target_include_directories()
> > is no longer possible with CMake and gcc > 6:
> >
> >
> > https://cmake.org/cmake/help/v3.10/command/target_include_directories.html?highlight=target_include_directories
> >
> 
> That’s right there is a patch I did  in WebKitgtk recipe in Oe Core you
> might want to include similar fixes for this package the patch actually it
> a workaround but then I also think using isystem in apps is a bad idea

Yes, I tend to agree, but developers have used this to silence compiler
warnings from system header files.

In a few cases I saw that there were no longer any warnings coming from the
headers but in some others there were.

Any other ideas how to suppress compiler wanings from system headers?

-Mikko

  reply	other threads:[~2018-08-24 16:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 12:33 [PATCH] cmake: add CMAKE_SYSROOT to generated toolchain file Pascal Bach
2018-08-24 14:15 ` Mikko.Rapeli
2018-08-24 14:43   ` Mikko.Rapeli
2018-08-24 15:10     ` Bach, Pascal
2018-08-24 15:44       ` Khem Raj
2018-08-24 15:48       ` Mikko.Rapeli
2018-08-24 15:51         ` Khem Raj
2018-08-24 16:17           ` Mikko.Rapeli [this message]
2018-08-24 16:23             ` Khem Raj
2018-08-24 16:41               ` Mikko.Rapeli
2018-08-24 16:44                 ` Khem Raj
2018-08-27 15:44 ` Khem Raj
2018-09-28 13:03   ` Bach, Pascal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180824161727.GL20864@hiutale \
    --to=mikko.rapeli@bmw.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.