Re: [PATCH v2 1/4] vin-tests: Add support for D3 Draak

[jacopo mondi <jacopo@jmondi.org>]

[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]

Hi Niklas,

On Fri, Aug 24, 2018 at 06:12:29PM +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your work.
>
> On 2018-08-24 12:24:19 +0200, Jacopo Mondi wrote:
> > Add support for D3 Draak board.
> >
> > Draak has its HDMI input connected to an ADV7612 which connects to VIN4
> > parallel data inputs.
> >
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  scripts/boards.sh | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/scripts/boards.sh b/scripts/boards.sh
> > index 26fdab9..7eb3a27 100644
> > --- a/scripts/boards.sh
> > +++ b/scripts/boards.sh
> > @@ -29,6 +29,13 @@ case $info in
> >          # for V3M, but results in an image.
> >          parallelformat="YUYV8_1X16"
> >          ;;
> > +    "Renesas Draak board based on r8a77995")
> > +        gen="gen3"
> > +        vins="4"
> > +        parallelname="adv7612 0-004c"
> > +        # FIXME: This is a hackfor D3, but results in an image.
> > +        parallelformat="YUYV8_1X16"
> > +        ;;
> >      "Koelsch")
> >          gen="gen2"
> >
> > @@ -70,6 +77,8 @@ if [[ "$gen" == "gen3" ]]; then
> >
> >          txaname="adv748x 0-0070 txa"
> >          txbname="adv748x 0-0070 txb"
> > +    elif [[ "$info" == "Renesas Draak board based on r8a77995" ]]; then
> > +        hdminame="adv7612 0-004c"
>
> I don't have the D3 schematics at hand but this feels wrong. Why do you
> define the adv7612 as both a parallel and CSI-2 source? IIRC the D3 have
> no CSI-2 IP?
>

Why is "hdminame" variable the CSI-2 source? It might as well be the
VIN source, as for D3.

To me, and I have added it here because it is used in yavta-hdmi in
this way, is the HDMI input component.

Want to change the name?

> The reason this exists for V3M is that it has both parallel input in the
> form of a adv7612 and a CSI-2 input in the for of a adv7482 connected to
> the CSI40 IP.
>
> >      else
> >          cvbsname="adv748x 4-0070 afe"
> >          hdminame="adv748x 4-0070 hdmi"
> > --
> > 2.7.4
> >
>
> --
> Regards,
> Niklas Söderlund

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]