From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar() Date: Fri, 24 Aug 2018 16:16:09 -0700 Message-ID: <20180824231609.GH6432@intel.com> References: <20180824203856.17700-1-dhinakaran.pandiyan@intel.com> <20180824221535.GD6432@intel.com> <65fba02a9b2589f7c65f3034bd8c0f86180ef7af.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 013766E75A for ; Fri, 24 Aug 2018 23:16:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <65fba02a9b2589f7c65f3034bd8c0f86180ef7af.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMjQsIDIwMTggYXQgMTA6Mjc6MDlQTSArMDAwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gCj4gCj4gT24gRnJpLCAyMDE4LTA4LTI0IGF0IDE1OjE1IC0wNzAwLCBS b2RyaWdvIFZpdmkgd3JvdGU6Cj4gPiBPbiBGcmksIEF1ZyAyNCwgMjAxOCBhdCAwMTozODo1NVBN IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdyb3RlOgo+ID4gPiBza2xfcGxhbmVfaGFzX3Bs YW5hciBpcyBoYXJkIHRvIHJlYWQsIHNpbXBsaWZ5IHRoZSBsb2dpYyBieQo+ID4gPiBjaGVja2lu ZyBmb3IKPiA+ID4gc3VwcG9ydCBpbiB0aGUgb3JkZXIgb2YgcGxhdGZvcm0sIHBpcGUgYW5kIHBs YW5lLgo+ID4gPiAKPiA+ID4gTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkgaW50ZW5kZWQuCj4g PiA+IAo+ID4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJh bi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIHwgMjcgKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gPiA+IC0t LQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0p Cj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+ IGluZGV4IDMwZmRmZDFhMzAzNy4uN2UxOGJkOGIyMWI4IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+IEBAIC0xMzYyMiwyNCArMTM2MjIsMTUgQEAg c3RhdGljIGJvb2wgc2tsX3BsYW5lX2hhc19mYmMoc3RydWN0Cj4gPiA+IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ID4gPiAgYm9vbCBza2xfcGxhbmVfaGFzX3BsYW5hcihzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ICAJCQkgIGVudW0gcGlwZSBwaXBlLCBlbnVt IHBsYW5lX2lkIHBsYW5lX2lkKQo+ID4gPiAgewo+ID4gPiAtCWlmIChwbGFuZV9pZCA9PSBQTEFO RV9QUklNQVJZKSB7Cj4gPiA+IC0JCWlmIChJU19TS1lMQUtFKGRldl9wcml2KSB8fCBJU19CUk9Y VE9OKGRldl9wcml2KSkKPiA+ID4gLQkJCXJldHVybiBmYWxzZTsKPiA+ID4gLQkJZWxzZSBpZiAo KElOVEVMX0dFTihkZXZfcHJpdikgPT0gOSAmJiBwaXBlID09Cj4gPiA+IFBJUEVfQykgJiYKPiA+ ID4gLQkJCSAhSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpCj4gPiA+IC0JCQlyZXR1cm4gZmFsc2U7 Cj4gPiA+IC0JfSBlbHNlIGlmIChwbGFuZV9pZCA+PSBQTEFORV9TUFJJVEUwKSB7Cj4gPiA+IC0J CWlmIChwbGFuZV9pZCA9PSBQTEFORV9DVVJTT1IpCj4gPiA+IC0JCQlyZXR1cm4gZmFsc2U7Cj4g PiA+IC0JCWlmIChJU19HRU1JTklMQUtFKGRldl9wcml2KSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYp Cj4gPiA+ID09IDEwKSB7Cj4gPiA+IC0JCQlpZiAocGxhbmVfaWQgIT0gUExBTkVfU1BSSVRFMCkK PiA+ID4gLQkJCQlyZXR1cm4gZmFsc2U7Cj4gPiA+IC0JCX0gZWxzZSB7Cj4gPiA+IC0JCQlpZiAo cGxhbmVfaWQgIT0gUExBTkVfU1BSSVRFMCB8fCBwaXBlID09Cj4gPiA+IFBJUEVfQyB8fAo+ID4g PiAtCQkJICAgIElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8Cj4gPiA+IElTX0JST1hUT04oZGV2X3By aXYpKQo+ID4gPiAtCQkJCXJldHVybiBmYWxzZTsKPiBeIEhlcmUgaXQgZG9lcywgb3IgYW0gSSBu b3Qgc2VlaW5nIHRoZSBwYXJhbnRoZXNpcyBjb3JyZWN0bHkuCgpkYW0uLi4gaXQgaXMgc28gYmFk IHRoYXQgSSBnb3QgY29uZnVzZWQgd2hlbiBkcmF3aW5nIGEKdGFibGUgaGVyZS4uLgoKbmlwOiBU aGUgbmFtZSBvZiB0aGUgZnVuY3Rpb24gc2VlbXMgd3Jvbmcgc2luY2UgInNrbF8iIGFsd2F5cwpy ZXR1cm4gZmFsc2UuLi4uCmJ1dCBJIGRvbid0IGhhdmUgYSBiZXR0ZXIgc3VnZ2VzdGlvbiAuLi4g bWF5YmUganVzdCAiaW50ZWxfIgphbmQgY2FuIGJlIGluIGEgZm9sbG93IHVwIHBhdGNoLi4uCgpz bywKClJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cgo+ IAo+ID4gPiAtCQl9Cj4gPiA+IC0JfQo+ID4gPiArCWlmIChJU19TS1lMQUtFKGRldl9wcml2KSB8 fCBJU19CUk9YVE9OKGRldl9wcml2KSkKPiA+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gCj4gPiBU aGUgY3VycmVudCBjb2RlIGlzIGluZGVlZCB1Z2x5LCBidXQgSSdtIGFmcmFpZCBpdCBkb2Vzbid0 IGFsd2F5cwo+ID4gcmV0dXJuCj4gPiBmYWxzZSBmb3IgdGhlc2UgcGxhdGZvcm1zLgo+ID4gCj4g PiBmb3IgaW5zdGFuY2UgcGxhbmVfaWQgPSBQTEFORV9TUFJJVEUwCj4gPiAKPiA+ID4gKwo+ID4g PiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID09IDkgJiYgIUlTX0dFTUlOSUxBS0UoZGV2X3By aXYpCj4gPiA+ICYmIHBpcGUgPT0gUElQRV9DKQo+ID4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiA+ ICsKPiA+ID4gKwlpZiAocGxhbmVfaWQgPT0gUExBTkVfQ1VSU09SIHx8IHBsYW5lX2lkICE9IFBM QU5FX1NQUklURTApCj4gPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ID4gKwo+ID4gPiAgCXJldHVy biB0cnVlOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+IC0tIAo+ID4gPiAyLjE3LjEKPiA+ID4gCj4g PiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK