diff for duplicates of <20180825093055.2cee2159@archlinux> diff --git a/a/1.txt b/N1/1.txt index 953fd4a..6a2b2dd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,19 +2,17 @@ On Thu, 23 Aug 2018 23:24:35 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > With gcc 4.1.2: ->=20 -> drivers/iio/proximity/isl29501.c: In function =E2=80=98isl29501_regis= -ter_write=E2=80=99: -> drivers/iio/proximity/isl29501.c:235: warning: =E2=80=98msb=E2=80=99 = -may be used uninitialized in this function ->=20 +> +> drivers/iio/proximity/isl29501.c: In function ‘isl29501_register_write’: +> drivers/iio/proximity/isl29501.c:235: warning: ‘msb’ may be used uninitialized in this function +> > While this is a false positive, it can easily be avoided by removing the > "msb" intermediate variable. > Remove the "lsb" intermediate variable for consistency. ->=20 +> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> -Looks sensible to me, but I'd obviously like to leave a little time for=20 +Looks sensible to me, but I'd obviously like to leave a little time for Mathieu to comment as it's his driver. Jonathan @@ -24,44 +22,41 @@ Jonathan > --- > drivers/iio/proximity/isl29501.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) ->=20 -> diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl= -29501.c +> +> diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl29501.c > index e5e94540f404dd2c..5ae549075b27c50d 100644 > --- a/drivers/iio/proximity/isl29501.c > +++ b/drivers/iio/proximity/isl29501.c -> @@ -232,7 +232,6 @@ static u32 isl29501_register_write(struct isl29501_pr= -ivate *isl29501, +> @@ -232,7 +232,6 @@ static u32 isl29501_register_write(struct isl29501_private *isl29501, > u32 value) > { -> const struct isl29501_register_desc *reg =3D &isl29501_registers[name]; +> const struct isl29501_register_desc *reg = &isl29501_registers[name]; > - u8 msb, lsb; > int ret; -> =20 +> > if (!reg->msb && value > U8_MAX) -> @@ -241,22 +240,15 @@ static u32 isl29501_register_write(struct isl29501_= -private *isl29501, +> @@ -241,22 +240,15 @@ static u32 isl29501_register_write(struct isl29501_private *isl29501, > if (value > U16_MAX) > return -ERANGE; -> =20 +> > - if (!reg->msb) { -> - lsb =3D value & 0xFF; +> - lsb = value & 0xFF; > - } else { -> - msb =3D (value >> 8) & 0xFF; -> - lsb =3D value & 0xFF; +> - msb = (value >> 8) & 0xFF; +> - lsb = value & 0xFF; > - } > - > mutex_lock(&isl29501->lock); > if (reg->msb) { -> ret =3D i2c_smbus_write_byte_data(isl29501->client, +> ret = i2c_smbus_write_byte_data(isl29501->client, > - reg->msb, msb); > + reg->msb, value >> 8); > if (ret < 0) > goto err; > } -> =20 -> - ret =3D i2c_smbus_write_byte_data(isl29501->client, reg->lsb, lsb); -> + ret =3D i2c_smbus_write_byte_data(isl29501->client, reg->lsb, value); -> =20 +> +> - ret = i2c_smbus_write_byte_data(isl29501->client, reg->lsb, lsb); +> + ret = i2c_smbus_write_byte_data(isl29501->client, reg->lsb, value); +> > err: > mutex_unlock(&isl29501->lock); diff --git a/a/content_digest b/N1/content_digest index 1cb0c6a..3984c85 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -16,19 +16,17 @@ "Geert Uytterhoeven <geert@linux-m68k.org> wrote:\n" "\n" "> With gcc 4.1.2:\n" - ">=20\n" - "> drivers/iio/proximity/isl29501.c: In function =E2=80=98isl29501_regis=\n" - "ter_write=E2=80=99:\n" - "> drivers/iio/proximity/isl29501.c:235: warning: =E2=80=98msb=E2=80=99 =\n" - "may be used uninitialized in this function\n" - ">=20\n" + "> \n" + "> drivers/iio/proximity/isl29501.c: In function \342\200\230isl29501_register_write\342\200\231:\n" + "> drivers/iio/proximity/isl29501.c:235: warning: \342\200\230msb\342\200\231 may be used uninitialized in this function\n" + "> \n" "> While this is a false positive, it can easily be avoided by removing the\n" "> \"msb\" intermediate variable.\n" "> Remove the \"lsb\" intermediate variable for consistency.\n" - ">=20\n" + "> \n" "> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>\n" "\n" - "Looks sensible to me, but I'd obviously like to leave a little time for=20\n" + "Looks sensible to me, but I'd obviously like to leave a little time for \n" "Mathieu to comment as it's his driver.\n" "\n" "Jonathan\n" @@ -38,46 +36,43 @@ "> ---\n" "> drivers/iio/proximity/isl29501.c | 12 ++----------\n" "> 1 file changed, 2 insertions(+), 10 deletions(-)\n" - ">=20\n" - "> diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl=\n" - "29501.c\n" + "> \n" + "> diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl29501.c\n" "> index e5e94540f404dd2c..5ae549075b27c50d 100644\n" "> --- a/drivers/iio/proximity/isl29501.c\n" "> +++ b/drivers/iio/proximity/isl29501.c\n" - "> @@ -232,7 +232,6 @@ static u32 isl29501_register_write(struct isl29501_pr=\n" - "ivate *isl29501,\n" + "> @@ -232,7 +232,6 @@ static u32 isl29501_register_write(struct isl29501_private *isl29501,\n" "> \t\t\t\t u32 value)\n" "> {\n" - "> \tconst struct isl29501_register_desc *reg =3D &isl29501_registers[name];\n" + "> \tconst struct isl29501_register_desc *reg = &isl29501_registers[name];\n" "> -\tu8 msb, lsb;\n" "> \tint ret;\n" - "> =20\n" + "> \n" "> \tif (!reg->msb && value > U8_MAX)\n" - "> @@ -241,22 +240,15 @@ static u32 isl29501_register_write(struct isl29501_=\n" - "private *isl29501,\n" + "> @@ -241,22 +240,15 @@ static u32 isl29501_register_write(struct isl29501_private *isl29501,\n" "> \tif (value > U16_MAX)\n" "> \t\treturn -ERANGE;\n" - "> =20\n" + "> \n" "> -\tif (!reg->msb) {\n" - "> -\t\tlsb =3D value & 0xFF;\n" + "> -\t\tlsb = value & 0xFF;\n" "> -\t} else {\n" - "> -\t\tmsb =3D (value >> 8) & 0xFF;\n" - "> -\t\tlsb =3D value & 0xFF;\n" + "> -\t\tmsb = (value >> 8) & 0xFF;\n" + "> -\t\tlsb = value & 0xFF;\n" "> -\t}\n" "> -\n" "> \tmutex_lock(&isl29501->lock);\n" "> \tif (reg->msb) {\n" - "> \t\tret =3D i2c_smbus_write_byte_data(isl29501->client,\n" + "> \t\tret = i2c_smbus_write_byte_data(isl29501->client,\n" "> -\t\t\t\t\t\treg->msb, msb);\n" "> +\t\t\t\t\t\treg->msb, value >> 8);\n" "> \t\tif (ret < 0)\n" "> \t\t\tgoto err;\n" "> \t}\n" - "> =20\n" - "> -\tret =3D i2c_smbus_write_byte_data(isl29501->client, reg->lsb, lsb);\n" - "> +\tret =3D i2c_smbus_write_byte_data(isl29501->client, reg->lsb, value);\n" - "> =20\n" + "> \n" + "> -\tret = i2c_smbus_write_byte_data(isl29501->client, reg->lsb, lsb);\n" + "> +\tret = i2c_smbus_write_byte_data(isl29501->client, reg->lsb, value);\n" + "> \n" "> err:\n" "> \tmutex_unlock(&isl29501->lock);" -56285ad8dbe81d34be7a69b33d9056eeb4dbbd06299134aec7ab8718c9255016 +a1efd43559d1921fb5a19e519975679ab4431d0524aaa94872a0b5d417c46399
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.