From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42263 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbeHYQ5J (ORCPT ); Sat, 25 Aug 2018 12:57:09 -0400 Date: Sat, 25 Aug 2018 15:18:06 +0200 From: jacopo mondi To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Laurent Pinchart , Jacopo Mondi , geert@linux-m68k.org, horms@verge.net.au, kieran.bingham+renesas@ideasonboard.com, damm+renesas@opensource.se, ulrich.hecht+renesas@gmail.com, linux-renesas-soc@vger.kernel.org Subject: Re: [RFT 0/8] arm64: dts: renesas: Ebisu: Add HDMI and CVBS input Message-ID: <20180825131806.GK26480@w540> References: <1534760202-20114-1-git-send-email-jacopo+renesas@jmondi.org> <12690843.BN01eCh2kh@avalon> <20180825063715.GI1493@bigcity.dyn.berto.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZrCu0B0FMx3UnjE2" Content-Disposition: inline In-Reply-To: <20180825063715.GI1493@bigcity.dyn.berto.se> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: --ZrCu0B0FMx3UnjE2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Laurent, Niklas, On Sat, Aug 25, 2018 at 08:37:15AM +0200, Niklas S=C3=B6derlund wrote: > Hi Laurent and Jacopo, > > On 2018-08-25 02:54:44 +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > > On Monday, 20 August 2018 13:16:34 EEST Jacopo Mondi wrote: > > > Hello renesas list, > > > this series add supports for the HDMI and CVBS input to R-Car E3 R= 8A77990 > > > Ebisu board. > > > > > > It's an RFT, as I don't have an Ebisu to test with :( > > > > > > The series adds supports for the following items: > > > > > > - PFC: add VIN groups and functions > > > - R-Car VIN and R-Car CSI-2: add support for R8A77990 > > > - R8A77990: Add I2C, VIN and CSI-2 nodes > > > - Ebisu: describe HDMI and CVBS inputs > > > > > > Each patch, when relevant reports difference between the upported BSP= patch > > > and the proposed one. > > > > > > I know Laurent should receive an Ebisu sooner or later, maybe we can = sync > > > for testing :) > > > > I've given the series a first test, and I think a bit more work is need= ed :-) > > > > [ 1.455533] adv748x 0-0070: Endpoint /soc/i2c@e6500000/video-receive= r@70/ > > port@7/endpoint on port 7 > > [ 1.464683] adv748x 0-0070: Endpoint /soc/i2c@e6500000/video-receive= r@70/ > > port@8/endpoint on port 8 > > [ 1.473728] adv748x 0-0070: Endpoint /soc/i2c@e6500000/video-receive= r@70/ > > port@a/endpoint on port 10 > > [ 1.484835] adv748x 0-0070: chip found @ 0xe0 revision 2143 > > [ 1.639470] adv748x 0-0070: No endpoint found for txb > > [ 1.644653] adv748x 0-0070: Failed to probe TXB > > I fear this is a design choice in the adv748x driver. Currently the > driver requires both of its two CSI-2 transmitters to be connected/used > else probe fails. Furthermore the HDMI capture is always routed to TXA > while the analog capture is always routed to TXB. > > Now that we have a board where only TXA is connected but both HDMI and > analog captures are used maybe it's time to do some more work on v4l2 > and the adv748x driver ;-P What's missing: > > - Probe should be OK with either TXA or TXB connected and not bail if > not both are used. I have three patches for this I hope to share as soon as I'll be able to do some more testing > - The media_device_ops or at least the .link_notify() callback of that > struct must be changed so not one driver in the media graph is > responsible for all links. In this case rcar-vin provides the callback > and rcar-vin should not judge which links between the adv748x > subdevices are OK to enable/disable. Currently the links between the > adv748x subdevices are immutably enabled to avoid this particular > problem. Uh, I didn't get this :/ Care to elaborate more? What I was about to do, instead, given the fixed HDMI->TXA and AFE->TXB routing in the adv748x driver was to insert a .link_validate() callback for both the HDMI and AFE backends, that checks for the availability of the corresponding output endpoint. This seems to me that this makes easy when dynamic routing will be added to do the same on the dynamically configured sink pad. What do you think? Thanks j > > > > > > PS: the list of upported patches will be sent separately. > > > > > > Jacopo Mondi (5): > > > media: dt-bindings: media: rcar-vin: Add R8A77990 support > > > media: rcar-vin: Add support for R-Car R8A77990 > > > dt-bindings: media: rcar-csi2: Add R8A77990 > > > media: rcar-csi2: Add R8A77990 support > > > arm64: dts: renesas: ebisu: Add HDMI and CVBS input > > > > > > Koji Matsuoka (1): > > > arm64: dts: r8a77990: Add VIN and CSI-2 device nodes > > > > > > Takeshi Kihara (2): > > > pinctrl: sh-pfc: r8a77990: Add VIN pins, groups and functions > > > arm64: dts: r8a77990: Add I2C device nodes > > > > > > .../devicetree/bindings/media/rcar_vin.txt | 1 + > > > .../bindings/media/renesas,rcar-csi2.txt | 1 + > > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 ++++ > > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 202 +++++++++ > > > drivers/media/platform/rcar-vin/rcar-core.c | 20 + > > > drivers/media/platform/rcar-vin/rcar-csi2.c | 9 + > > > drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 504 +++++++++++= +++++++ > > > 7 files changed, 823 insertions(+) > > > > -- > > Regards, > > > > Laurent Pinchart > > > > > > > > -- > Regards, > Niklas S=C3=B6derlund --ZrCu0B0FMx3UnjE2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJbgVcNAAoJEHI0Bo8WoVY87OIQAID1lRycKi8UT0oVR1UUMu/4 Fapu67hDbusLWK5B4mCGxRTDuinx6shwUu4H3foKpNFEViYfTvnPHqF1T7scxAXh TbItdsvZfeyioYtreTHnYrPSv/mg45CsopLrPdAmlSb3GMp2libq+Am5/N8uWJww PQMlWRzEFSkD/YPMno19N1ayGKYNkMVfFy3DGSdHa6zxP4rxxV0veQ48mn9Owzzz q8n6jra7IRpOhSBounTxMnK8qf3dzbuPzCjJ5t7GNW67+lySNQT5RmxS3iL8H63s jLj7Hlm8NgA2DAk28zhFiMclDxaL5iV1MwIYKZIW3ZCRpvmZRuZyVdF/WsuRQDVt xJOxSi3bs+THR4OJtAB8APMTFPT+KrqD7I+1xHwyWBcRXTzC0ivpPkAiiTrqspxK 9KnyQ7zTfi3545m+0zBniQSdWmnzZh177XYSD10KuilPN0ryunXVH7JDbuKgiHxJ SRom6w2nl3IOpa0oKw0faQsYkAsc2IVzhuwt5ugMqfQEh1Mh8DEa5BdsnHOGA0fn n/IrcD3Pr+Rg/wFJSFxmSF2pqIHi/DgyLWmYM2p0VnORxJz2+1FOq8gZYYWT+6QP bJMCBtq24h9lDXU5PaIoqCShvgh/vuT/bdgbBu2M1pURvz089U0tT1YepDh9RGgV s9OwifKx+ujfBVcH+4wr =4CYd -----END PGP SIGNATURE----- --ZrCu0B0FMx3UnjE2--