From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] git: Fix libintl linking if there is no full gettext support
Date: Sat, 25 Aug 2018 14:12:05 +0200 [thread overview]
Message-ID: <20180825141205.4c5c7667@windsurf> (raw)
In-Reply-To: <CAMw6YJKnyLbSO7FMf5ws5_vnEKS8TkZY1u_598YddvOm79J4GA@mail.gmail.com>
Hello Vadim,
On Sat, 25 Aug 2018 14:24:37 +0300, Vadim Kochan wrote:
> > Could you give some minimal Buildroot configuration that exhibits the
> > issue ?
>
> So I just did:
> 1) make menuconfig
> 2) Toolchain -> WCHAR
> 3) System -> NLS
> 4) Target packages -> Development -> git
>
> I attached also config file w/o '#' and empty lines.
>
> P.S.
> Not sure if the fix is good, will try to cook v2 ...
OK, I can reproduce (we should really add some testing for NLS enabled
in our autobuilders, let's do this after the 2018.08 release). However,
the proper fix is:
ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
GIT_MAKE_OPTS += NO_GETTEXT=1
+else
+GIT_EXTLIBS += $(TARGET_NLS_LIBS)
endif
TARGET_NLS_LIBS is automaticaly set to -lintl when gettext provides the
full libintl library we need to link against.
Could you test this, and send an updated patch ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-25 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 13:20 [Buildroot] [PATCH 1/1] git: Fix libintl linking if there is no full gettext support Vadim Kochan
2018-08-24 21:09 ` Thomas Petazzoni
2018-08-25 11:24 ` Vadim Kochan
2018-08-25 12:12 ` Thomas Petazzoni [this message]
2018-08-25 12:25 ` Vadim Kochan
2018-08-25 12:36 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825141205.4c5c7667@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.